354334 - Background of bookmarks toolbar doesn't properly handle taller items

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Bart Szyszka]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0

This wasn't an issue in previous version of Firefox until the new theme was introduced in Firefox 2 beta 2. The background image used for the bookmarks toolbar can't properly handle items that are taller than the bookmark text. This is an issue with the Google Browser Sync extension which places things in the toolbar that increase its height.

It's also a problem with the FireBug extension which uses the same background image for its toolbar, though that may need to be something that extension's developer needs to address himself. My screenshot (see URL) includes both.

Reproducible: Always

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Microscopic CSS-only fix

Multiple screenshots to come, more if you have other ideas you want to see shot.

Comment 2

[Phil Ringnalda (:philor)]

*** Bug 354377 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Current default

The current default state, plus a button on the toolbar. Note that (due to a bug I don't remember, but am probably cc'ed on anyway) to reproduce you need to have changed your icon size at least once: if you start with default large icons, and add a button to the ptf, you get a small icon there, but once you change the nav toolbar to small icons, then the ones on the ptf will change size along with the others.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: Current worst-case

We're looking particularly awful if you have large icons plus text.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fixed, large icons

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Fixed, small icons

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Fixed, icons + text

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Low low risk, high high yield. You're in.

Comment 9

[Asaf Romano (gone)]

1.8: mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.50
trunk: mozilla/browser/themes/pinstripe/browser/browser.css 1.32

Comment 10

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060928 BonEcho/2.0