Closed
Bug 354373
Opened 18 years ago
Closed 18 years ago
"Report Broken Web Site" is after "Report Web Forgery" on Linux but shouldn't
Categories
(Firefox :: Menus, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
Details
(Keywords: fixed1.8.1, polish, Whiteboard: [Fx 2.0.0.1])
Attachments
(1 file)
|
2.61 KB,
patch
|
asaf
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
See bug 353388 comment 6:
Both "Report Broken Web Site" and "Report Web Forgery" want to be before the separator in the menu:
http://lxr.mozilla.org/mozilla1.8/source/browser/components/safebrowsing/content/report-phishing-overlay.xul#53
http://lxr.mozilla.org/mozilla1.8/source/extensions/reporter/resources/content/reporter/reporterOverlay.xul#58
On Windows, "Report Broken Web Site" is before "Report Web Forgery". That's the intended sequence according to bug 353388 comment 8.
On Linux, I see it the other way round.
|
Assignee | |
Comment 1•18 years ago
|
||
Adds an id to the Release Notes menu item, and tells "Report Broken Web Site" to show up after that.
|
|
Assignee | |
Updated•18 years ago
|
Attachment #240204 -
Flags: review? → review?(mano)
|
|
Assignee | |
Comment 2•18 years ago
|
||
I'd like to fix this for Firefox 2.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
|
|
Assignee | |
Updated•18 years ago
|
Summary: 'Report Broken Web Site" is after "Report Web Forgery" on LInux but shouldn't → "Report Broken Web Site" is after "Report Web Forgery" on Linux but shouldn't
|
||
Comment 3•18 years ago
|
||
Maybe in a dot release, but this polish isn't essential for final release.
|
||
Comment 4•18 years ago
|
||
Comment on attachment 240204 [details] [diff] [review]
patch
OK, r=mano.
Attachment #240204 -
Flags: review?(mano) → review+
|
||
Comment 5•18 years ago
|
||
For what it's worth, using a Linux trunk and branch tinderbox build from today, "Report Broken Web Site" appears before "Report Web Forgery"; e.g. the order is correct.
|
|
Assignee | |
Comment 6•18 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•18 years ago
|
Attachment #240204 -
Flags: approval1.8.1?
|
||
Comment 7•18 years ago
|
||
Comment on attachment 240204 [details] [diff] [review]
patch
a=mconnor on behalf of drivers for checkin _today_
please land ASAP
Attachment #240204 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Comment 8•18 years ago
|
||
I'm away from my dev machine for the next 11-12 hours or so.
Whiteboard: [Fx 2.0.0.1] → [Fx 2.0.0.1][1.8 branch checkin needed]
|
||
Comment 9•18 years ago
|
||
Fixed on branch.
Keywords: fixed1.8.1
Whiteboard: [Fx 2.0.0.1][1.8 branch checkin needed] → [Fx 2.0.0.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•