Closed Bug 353388 Opened 18 years ago Closed 18 years ago

menu reference: "Report Web Forgery" is before "Report Broken Website"

Categories

(Firefox Graveyard :: Help Documentation, defect)

Product:
Firefox Graveyard
Component:
Help Documentation
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED INVALID
Milestone:
Firefox 2

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

(Keywords: late-l10n, Whiteboard: [help fix only])

Attachments

(1 file)

move "Report Web Forgery" to the right place in the document
4.45 KB, patch
steffen.wilberg
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
 
Just in case we get the chance to fix this glitch.

This is branch only; I already fixed it on trunk (bug 343857).
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #239249 - Flags: review+
Attachment #239249 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Marking as blocking in case we need an RC2, otherwise this'll miss release.
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [rc ridealong][help fix only]
Comment on attachment 239249 [details] [diff] [review]
move "Report Web Forgery" to the right place in the document

Approved for RC2 (Help only).
Attachment #239249 - Flags: approval1.8.1? → approval1.8.1+
Fixed on branch.
Trunk fix was already part of bug 343857.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Depends on: 343857
Keywords: fixed1.8.1
Resolution: --- → FIXED
(In reply to comment #4)
> Fixed on branch.

Two questions come up:
1. Should localisers update this for RC2?
2. Shouldn't this be fixed in the GUI itself in the first place?
Blocks: 354043
No longer depends on: 354043
Oh dear, there are funky things going on:
In my self-compiled Linux builds (trunk and branch) the menu looks like this:
Report Web Forgery...
Report Broken Website...
The documentation said it was the other way round, so I filed this bug.

But on this Windows nightly (20060921) the menu looks the other way round:
Report Broken Website...
Report Web Forgery...

Maybe that's because both menu items want to be inserted before the separator:
http://lxr.mozilla.org/mozilla1.8/source/browser/components/safebrowsing/content/report-phishing-overlay.xul#53
http://lxr.mozilla.org/mozilla1.8/source/extensions/reporter/resources/content/reporter/reporterOverlay.xul#58

OK, so what's the desired sequence of the menu items? We can then fix the UI and, if necessary, the documentation.
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1
Resolution: FIXED → ---
> In my self-compiled Linux builds (trunk and branch) the menu looks like this:
> Report Web Forgery...
> Report Broken Website...
> The documentation said it was the other way round, so I filed this bug.

So it is in Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1) Gecko/2006092404 BonEcho/2.0
Whiteboard: [rc ridealong][help fix only] → [checkin needed (1.8 branch)][help fix only]
Whiteboard: [checkin needed (1.8 branch)][help fix only] → [help fix only]
Keywords: uiwanted
I've never seen it appear as anything other than was intended, which is what the documentation reflects:

  Report Broken Web Site ...
  Report Web Forgery ...
Keywords: uiwanted
Then we need to backout this patch since it is wrong, at least on Windows as it seems.

And we need to make sure the UI always appears in the sequence mentioned in comment 8.
Severity: normal → trivial
Whiteboard: [help fix only] → [help fix only][backout needed 1.8 branch & trunk]
Backed out.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Flags: blocking-firefox2+
Resolution: --- → INVALID
Whiteboard: [help fix only][backout needed 1.8 branch & trunk] → [help fix only]
I filed bug 354373 to make sure the UI always follows the intended sequence, and attached a patch.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: