354443 - navigator.registerContentHandler doesn't sanity-check type/title args.

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Daniel Veditz [:dveditz]]

Spun off from bug 354316 comment 2

navigator.registerContentHandler doesn't sanity-check the type or title arguments (uri arg is handled in bug 354316).

The type should be restricted to the characters that are allowed as a MIME type:
    // reject types that contain characters other than
    // alphanumerics or '.', '-', '+', '/'
    if (contentType.match(/[^-./+a-z0-9]/i) )
         throw("Invalid MIME type");

Maybe there are a few other allowable characters, but it should be a whitelist of good characters rather than an attempt to filter bad ones.

Currently we silently drop non-feed types, the whatwg spec says we should raise an exception for types we deem privileged like text/html. It'd be odd to raise an exception for some types and not others, we should probably raise an exception no matter the reason we reject the type.

Not sure what checking we should do on the title. It gets saved as a pref and shown in a couple of different dialogs (as text, a listbox, a drop down). We'd want to allow localized text. Maybe just strip our control characters?

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Requesting [wanted-firefox3].

Comment 2

[cmtalbert]

Don't we also need this for the "registerProtocolHandler" API?

Should I make a spin off bug or is this one enough?

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

ctalbert: spinoff bug would be good here, I think.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

With a few exceptions, I'm mostly focused on MailCo-related hacking now.  Reassigning a bunch of bugs to default component owners.  I'm happy to help with brainstorming/advice as needed, however.  

Search for the string MAILMONKEY to delete any bugmail generated by this change.

Comment 5

[cmtalbert]

(In reply to comment #3)
> ctalbert: spinoff bug would be good here, I think.
Sorry, this fell through the cracks.  Filed bug 463164.

Comment 6

[Jonathan Kingston [:jkt] he/him]

As of Bug 1460481 we should WONTFIX this.