354465 - Ability to remember username and password for CalDav calendar is lost

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Sebastian Schwieger]

If you subscribe to a CalDAV calendar you cannot choose that Sunbird should remember username and password (checkbox). This is a regression as it worked up to Sunbird 20060919. It fails from Sunbird 20060920 on.

STR:

1. subscribe to CalDAV calendar
2. enter username and password in pop up dialog

Result: There is no checkbox to remember the entered information

using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060927 Calendar/0.3a2+

Comment 1

[Matthew (lilmatt) Willis]

This was due to the checkin for bug 351199
mozilla/calendar/providers/caldav/calDavCalendar.js 1.68

If we remove the if case for Components.interfaces.nsIAuthPrompt2, the checkbox returns. 

Once dmose arrives, I'll chat with him about how we want to handle this.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev0 - Fix nsiAuthPrompt2 and remove unnecessary nsIDocTreeShell reference

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 240360 [details] [diff] [review]
rev0 - Fix nsiAuthPrompt2 and remove unnecessary nsIDocTreeShell reference

r=dmose

Comment 4

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED