Closed Bug 354522 Opened 19 years ago Closed 19 years ago

misplaced return rv; in nsWindowWatcher

Categories

(Core Graveyard :: Embedding: APIs, defect)

Product:
Core Graveyard
Component:
Embedding: APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Biesinger, Assigned: Biesinger)

References

(
URL
)

Details

Attachments

(2 files)

moves nsresult rv outside the if
1021 bytes, patch
Biesinger
: review+
dmosedale
: superreview+
Details | Diff | Splinter Review
unit test for this
1.95 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
I put the return rv; in the wrong place (see URL), it should be outside the scope it's in so that all nsIAuthPrompt2 cases hit it.
Attachment #240339 - Flags: review?(cbiesinger)
Attachment #240339 - Flags: superreview?(darin)
Attachment #240339 - Flags: review?(cbiesinger)
Attachment #240339 - Flags: review+
Comment on attachment 240339 [details] [diff] [review] moves nsresult rv outside the if sr=dmose, after discussion with biesi so that we can get this in the tree quickly in order to branch for Sunbird 0.3.
Attachment #240339 - Flags: superreview?(darin) → superreview+
Comment on attachment 240339 [details] [diff] [review] moves nsresult rv outside the if sr=dmose, after discussion with biesi so that we can get this in the tree quickly in order to branch for Sunbird 0.3.
Patch checked in on trunk. -> FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 354465
Comment on attachment 240354 [details] [diff] [review] unit test for this Kinda sucks that embedding/tests is already taken...
Attachment #240354 - Flags: review?(benjamin) → review+
well, putting these tests into a unit/ directory seems pretty standard. unit test checked in
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: