354470 - Add missing line for the security pane to the help code in pageinfo dialog

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Axel Hecht [:Pike]]

pageinfo.js and xul still try to expose help, likely leftovers from the suite version of it.
But the help pages don't exist, and pressing F1 just errors, as pageinfo.xul doesn't pull contextHelp.js.

We should either make help in page info work again (nah, not really) or just remove the traces, that is, the cmd in pageinfo.xul and doHelpButton in pageinfo.js.

Comment 1

[Brian Polidoro]

This bug, bug 339102, and bug 314211 should probably be coordinated so they are all in agreement.  

Comment 2

[Florian Quèze [:florian]]

The help page still doesn't exist but that should be fixed in bug 314221.
Now that bug 339102 is fixed, pageInfo.xul pulls contextHelp.js and doHelpButton is nearly correct.
A line for the security panel is missing in helpTopics though. I will attach a patch here for that if it doesn't get fixed in bug 377076.

Comment 3

[Florian Quèze [:florian]]

Attachment: patch

(In reply to comment #2)
> The help page still doesn't exist but that should be fixed in bug 314221.

I meant in bug 314211 of course.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 262694 [details] [diff] [review]
patch

r=mano

Comment 5

[Nickolay_Ponomarev]

Checking in pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.4; previous revision: 1.3
done

resummarized (was: Remove help entry points or hook them up from pageinfo)