Add missing line for the security pane to the help code in pageinfo dialog

RESOLVED FIXED in Firefox 3 alpha5

Status

()

Firefox
Page Info Window
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Pike, Assigned: florian)

Tracking

Trunk
Firefox 3 alpha5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
pageinfo.js and xul still try to expose help, likely leftovers from the suite version of it.
But the help pages don't exist, and pressing F1 just errors, as pageinfo.xul doesn't pull contextHelp.js.

We should either make help in page info work again (nah, not really) or just remove the traces, that is, the cmd in pageinfo.xul and doHelpButton in pageinfo.js.

Comment 1

11 years ago
This bug, bug 339102, and bug 314211 should probably be coordinated so they are all in agreement.  
(Assignee)

Comment 2

10 years ago
The help page still doesn't exist but that should be fixed in bug 314221.
Now that bug 339102 is fixed, pageInfo.xul pulls contextHelp.js and doHelpButton is nearly correct.
A line for the security panel is missing in helpTopics though. I will attach a patch here for that if it doesn't get fixed in bug 377076.
Assignee: nobody → f.qu
Version: 2.0 Branch → Trunk
(Assignee)

Comment 3

10 years ago
Created attachment 262694 [details] [diff] [review]
patch

(In reply to comment #2)
> The help page still doesn't exist but that should be fixed in bug 314221.

I meant in bug 314211 of course.
Attachment #262694 - Flags: review?(mano)
Comment on attachment 262694 [details] [diff] [review]
patch

r=mano
Attachment #262694 - Flags: review?(mano) → review+
(Assignee)

Updated

10 years ago
Whiteboard: [checkin needed]

Comment 5

10 years ago
Checking in pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.4; previous revision: 1.3
done

resummarized (was: Remove help entry points or hook them up from pageinfo)
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Summary: Remove help entry points or hook them up from pageinfo → Add missing line for the security pane to the help code in pageinfo dialog
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha5
You need to log in before you can comment on or make changes to this bug.