354538 - DOM Inspector Entities Need to be added.

Status: VERIFIED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Shawn Wilsher :sdwilsh]

Entities were added from Bug 205872.  These belong in viewers/domNode.dtd

<!ENTITY nodeValue.label "Node Value:">

<!ENTITY namespaceTitle.null.label "null">
<!ENTITY namespaceTitle.default.label "Document Default">

<!-- LOCALIZATION NOTE: DO NOT LOCALIZE These are generic Namespaces -->
<!ENTITY namespaceTitle.XMLNS.label "XMLNS">
<!ENTITY namespaceTitle.XML.label "XML">
<!ENTITY namespaceTitle.XHTML.label "XHTML">
<!ENTITY namespaceTitle.XLink.label "XLink">
<!ENTITY namespaceTitle.XSLT.label "XSLT">
<!ENTITY namespaceTitle.XBL.label "XBL">
<!ENTITY namespaceTitle.MathML.label "MathML">
<!ENTITY namespaceTitle.RDF.label "RDF">
<!ENTITY namespaceTitle.XUL.label "XUL">
<!ENTITY namespaceTitle.SVG.label "SVG">
<!ENTITY namespaceTitle.XMLEvents.label "XML Events">
<!ENTITY namespaceTitle.WAIRoles.label "WAI Roles">
<!ENTITY namespaceTitle.WAIProperties.label "WAI Properties">
<!ENTITY namespaceTitle.custom.label "Custom">

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

This also includes the stuff from bug 343463 (which has been waiting like forever for check in) and some other things that have been changed in  DOM Inspector, but the localizers haven't been made aware of.

Please check this in.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 240600 [details] [diff] [review]
Patch

pike?

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 240600 [details] [diff] [review]
Patch

approval-l10n has no meaning here, nor elsewhere, really.

I expect that you want to patch the extensions/inspector/resources/Makefile.in, too, and see if you can get a check-in buddy.

sdwilsh?

Comment 4

[Marek Stępień [:marcoos, inactive]]

Attachment: Previous patch + Makefile.in

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

I can check this in, I just was sure that it requires approval to get it in *^^* I'm tired ;)

Comment 6

[Marek Stępień [:marcoos, inactive]]

So, gandalf, will you check this in?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I was about to check this in, but it seems it's already out of date:
Comparing pl to en-US
Entities in ./inspector.dtd don't match:
  In /i/moz/mozilla/extensions/inspector/resources/locale/en-US: (add these keys to you localization)
    mnInspectContentDocument.label
    mnInspectContentDocument.accesskey
    mnInspectChromeDocument.label
    mnInspectChromeDocument.accesskey

Do you want me to check in the dtd changes only?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(the updates that need to be made are due to bug 337069)

Comment 9

[Marek Stępień [:marcoos, inactive]]

Attachment: Updated patch

This one adds the mnInspect* strings as well.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I checked that patch in.
mozilla/extensions/inspector/resources/locale/pl/inspector.properties 	1.3
mozilla/extensions/inspector/resources/locale/pl/viewers/dom.dtd 	1.3
mozilla/extensions/inspector/resources/locale/pl/viewers/domNode.dtd 	1.4
mozilla/extensions/inspector/resources/locale/pl/viewers/jsObject.dtd 	1.3
mozilla/extensions/inspector/resources/locale/pl/inspector.dtd 	1.4
mozilla/extensions/inspector/resources/Makefile.in 	1.27

Comment 11

[Marek Stępień [:marcoos, inactive]]

Thank you, Gavin. :)

Comment 12

[Marek Stępień [:marcoos, inactive]]

Verified with Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9a1) Gecko/2006111704 Minefield/3.0a1