354979 - Timezone names sorted by their English names

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Marek Stępień [:marcoos, inactive]]

Timezone picker in Sunbird prefs sorts the timezone names by their English names.

So, this may be correct for en-US:

Africa/Bujumbura
Africa/Cairo
Africa/Casablanca
...
Europe/Vienna
Europe/Vilnius
Europe/Warsaw

but it may not be correct in other locales. It _is_ incorrect in Polish:

Afryka/Bu¿umbura   (Polish for: Bujumbura)
Afryka/Kair        (Cairo)
Afryka/Casablanca
...
Europa/Wiedeñ      (Vienna)
Europa/Wilno       (Vilnius)
Europa/Warszawa    (Warsaw)

This should be:

Afryka/Bu¿umbura
Afryka/Casablanca
...
Afryka/Kair         (Cairo)
...
Europa/Warszawa     (Warsaw)
Europa/Wiedeñ       (Vienna)
Europa/Wilno        (Vilnius)

etc.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Current behavior (wrong)

Comment 2

[Cédric Corazza]

Marek,
Why don't you just sort these strings according to your language?
That's what we've done for the fr locale and it works fine.

Comment 3

[Marek Stępień [:marcoos, inactive]]

Cedric, where have you "sorted" them? The order in the DTD doesn't matter. 
The order is hard-coded the XUL file.

http://lxr.mozilla.org/mozilla1.8/source/calendar/base/content/preferences/timezones.xul#68

Comment 4

[Cédric Corazza]

(In reply to comment #3)
> Cedric, where have you "sorted" them? The order in the DTD doesn't matter. 
> The order is hard-coded the XUL file.

Oops : you're right :-) . I didn't notice that some of them are still in a wrong alphabetical order. Well, I ordered my dtd file for nothing :-).

Comment 5

[RickieES aka Ricardo Palomares]

Now that the timezones have been moved to timezones.properties, does the sorting problem persist?

Comment 6

[Daniel Boelzle [:dbo]]

I don't think so. The timezones' display names are sorted with local time and GMT at the top.

Comment 7

[Stefan Sitter [:ssitter]]

This should be tested once we have translated timezone names back (bug 437441).

Comment 8

[Daniel Boelzle [:dbo]]

Stefan, I don't think this depends on the mentioned bug. Even though not all locales are packaged up in a single calendar-timezones.xpi, the matching timezones.properties for Sunbird (via preinstalled via calendar-timezones) and lightning (via jar.mn) is available.

Comment 9

[gekacheka]

I think this was intended to be fixed by bug 363191.
However, it sorts the names using Array.sort(), which sorts by Unicode code.
Instead it should use Array.sort(String.localeCompare).
For example

["m", "o", "n", "ñ", "p"].sort()
--> m, n, o, p, ñ

["m","o", "n", "ñ",  "p"].sort(String.localeCompare)
--> m, n, ñ, o, p

Comment 10

[gekacheka]

Attachment: patch v1: sort timezones display names with Array.sort(String.localeCompare)

(patch -l -p 1 -i file.patch)

Use Array.sort(String.localeCompare) instead of Array.sort()
(Array.sort just sorts in Unicode order, which is not appropriate for many characters such as those with diacritical marks, and those that differ only by case.)

Comment 11

[Daniel Boelzle [:dbo]]

Comment on attachment 337246 [details] [diff] [review]
patch v1: sort timezones display names with Array.sort(String.localeCompare)

The event dialog needs that fix, too.

r=dbo with that done

Comment 12

[Daniel Boelzle [:dbo]]

Attachment: patch v2: sort timezones display names with Array.sort(String.localeCompare)

Checked in on HEAD, MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH.