355112 - Get rid of feeds-disabled code in browser/ (MOZ_FEEDS, --disable-feeds)

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Description

[Asaf Romano (gone)]

We should remove any feeds-disabled (#ifndef MOZ_FEEDS) code in browser/. I'll talk to Benjamin later on including the feeds toolkit component by default (thus, getting rid of --enable/disable-feeds) and file a separate bug per se.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 240917 [details] [diff] [review]
patch

Seems to me that this patch makes the following keys unused: addLiveBookmarkMenuitem, addLiveBookmarkMenupopup, feedShowFeed, feedHasFeeds. Any reason why you didn't remove them?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This would also break things pretty badly for people who use --disable-feeds, right? Why can't we just remove it all in one shot?

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 241251 [details] [diff] [review]
patch

You forgot to remove addLiveBookmarkMenuitem.label and addLiveBookmarkMenupopup.label from browser.dtd, and it looks like you forgot a couple of MOZ_FEEDS in browser/components/build (nsModule.cpp and Makefile.in).

Comment 6

[Asaf Romano (gone)]

Attachment: patch

Comment 7

[Asaf Romano (gone)]

mozilla/browser/app/profile/firefox.js 1.164
mozilla/browser/base/content/browser-menubar.inc 1.102
mozilla/browser/base/content/browser.js 1.713
mozilla/browser/base/content/browser.xul 1.323
mozilla/browser/components/Makefile.in 1.58
mozilla/browser/components/build/Makefile.in 1.48
mozilla/browser/components/build/nsModule.cpp 1.47
mozilla/browser/components/preferences/preferences.xul 1.11
mozilla/browser/locales/jar.mn 1.59
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 1.55
mozilla/browser/locales/en-US/chrome/browser/browser.properties 1.31
mozilla/browser/themes/pinstripe/browser/jar.mn 1.31
mozilla/browser/themes/winstripe/browser/jar.mn 1.29