Closed Bug 355112 Opened 17 years ago Closed 17 years ago

Get rid of feeds-disabled code in browser/ (MOZ_FEEDS, --disable-feeds)

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 3 alpha1

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file, 2 obsolete files)

patch
28.77 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
We should remove any feeds-disabled (#ifndef MOZ_FEEDS) code in browser/. I'll talk to Benjamin later on including the feeds toolkit component by default (thus, getting rid of --enable/disable-feeds) and file a separate bug per se.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #240917 -
        Flags: review?(gavin.sharp)

    
  
Priority: -- → P2

    
    

    
  
Comment on attachment 240917 [details] [diff] [review]
patch

Seems to me that this patch makes the following keys unused: addLiveBookmarkMenuitem, addLiveBookmarkMenupopup, feedShowFeed, feedHasFeeds. Any reason why you didn't remove them?

    
    

    
  
This would also break things pretty badly for people who use --disable-feeds, right? Why can't we just remove it all in one shot?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #240917 -
        Attachment is obsolete: true

        Attachment #241251 -
        Flags: review?(gavin.sharp)

        Attachment #240917 -
        Flags: review?(gavin.sharp)

    
  
Summary: Get rid of feeds-disabled code in browser/ → Get rid of feeds-disabled code in browser/ (MOZ_FEEDS, --disable-feeds)

    
    

    
  
Comment on attachment 241251 [details] [diff] [review]
patch

You forgot to remove addLiveBookmarkMenuitem.label and addLiveBookmarkMenupopup.label from browser.dtd, and it looks like you forgot a couple of MOZ_FEEDS in browser/components/build (nsModule.cpp and Makefile.in).

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #241251 -
        Attachment is obsolete: true

        Attachment #241653 -
        Flags: review?(gavin.sharp)

        Attachment #241251 -
        Flags: review?(gavin.sharp)

        Attachment #241653 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
mozilla/browser/app/profile/firefox.js 1.164
mozilla/browser/base/content/browser-menubar.inc 1.102
mozilla/browser/base/content/browser.js 1.713
mozilla/browser/base/content/browser.xul 1.323
mozilla/browser/components/Makefile.in 1.58
mozilla/browser/components/build/Makefile.in 1.48
mozilla/browser/components/build/nsModule.cpp 1.47
mozilla/browser/components/preferences/preferences.xul 1.11
mozilla/browser/locales/jar.mn 1.59
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 1.55
mozilla/browser/locales/en-US/chrome/browser/browser.properties 1.31
mozilla/browser/themes/pinstripe/browser/jar.mn 1.31
mozilla/browser/themes/winstripe/browser/jar.mn 1.29
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.