__noSuchMethod__ e4x/extensions/regress-312196.js FAILED

VERIFIED FIXED

Status

()

Core
JavaScript Engine
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: bc, Assigned: Igor Bukanov)

Tracking

({regression})

Trunk
x86
All
regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.1 -
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
trunk only regression first appears 20060921. previous run on 20060919 worked.

STATUS: Extending E4X XML objects with __noSuchMethod__
FAILED!: Section 1 of test -
FAILED!: Expected value:
FAILED!: <object uri="http://localhost">
FAILED!: <request method="sample"/>
FAILED!: <parameter>this</parameter>
FAILED!: <parameter>is</parameter>
FAILED!: <parameter>a</parameter>
FAILED!: <parameter>test</parameter>
FAILED!: </object>
FAILED!: Actual value:
FAILED!: TypeError: undefined is not a function
FAILED!:
FAILED!: Section 2 of test -
FAILED!: Expected value:
FAILED!: <object uri="http://localhost">
FAILED!: <request method="sample"/>
FAILED!: <parameter>this</parameter>
FAILED!: <parameter>is</parameter>
FAILED!: <parameter>a</parameter>
FAILED!: <parameter>test</parameter>
FAILED!: <parameter>this</parameter>
FAILED!: <parameter>is</parameter>
FAILED!: <parameter>a</parameter>
FAILED!: <parameter>test</parameter>
FAILED!: </object>
FAILED!: Actual value:
FAILED!: TypeError: ws.sample is not a function
FAILED!:
(Reporter)

Comment 1

12 years ago
Also appeared on 1.8 20061010. 20061009 passed.
Flags: blocking1.8.1.1?
Doesn't look like a fix is appearing, needs an owner to be a realistic blocker.
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1-
The 1.8.1.x triage team has no clue whether this is a regression we'd care to block on or not. Please advise.
I'm not the guy to ask, at this point.  waldo and igor may have thoughts.

/be

Comment 5

12 years ago
Ordinarily I'd say this is E4X and SpiderMonkey-specific behavior and not to worry about it; the fact that the original bug was submitted from real-life use, however, worries me a little.  I don't know enough about JS users to say how common use of __noSuchMethod__ is in the base of web-based code which is willing to both use E4X and willing to use SpiderMonkey-specific extensions.  Still, my inclination would be to say that this can probably wait for 1.8.1.2.

I looked at this in a debugger, and by the time execution enters NoSuchMethod |this| is undefined, so something's wrong upstream of that code.

Also possibly of note is that while looking at this I ran into bug 364017, which apparently isn't related to the recent slot refactoring work on trunk.
(Reporter)

Updated

12 years ago
Summary: e4x/Regress/regress-312196.js FAILED → e4x/extensions/regress-312196.js FAILED
(Assignee)

Updated

12 years ago
Assignee: general → igor

Updated

11 years ago
Blocks: 246441

Updated

11 years ago
Blocks: 312196
Summary: e4x/extensions/regress-312196.js FAILED → __noSuchMethod__ e4x/extensions/regress-312196.js FAILED

Updated

11 years ago
Blocks: 371033
(Reporter)

Comment 6

10 years ago
bug 420399 changed the behavior of 

section 1 still fails, however with but no longer with the 'TypeError: ws.function::sample is not a function' error. Instead it has a difference in the expected values.

expected:
<object uri="http://localhost">NL  <request method="sample"/>NL  <parameter>this</parameter>NL  <parameter>is</parameter>NL  <parameter>a</parameter>NL  <parameter>test</parameter>NL</object> actual: 

actual:
<object uri="http://localhost">NL  <request method="@mozilla.org/js/function::sample"/>NL  <parameter>this</parameter>NL  <parameter>is</parameter>NL  <parameter>a</parameter>NL  <parameter>test</parameter>NL</object>

section 2 now passes.
(Reporter)

Comment 7

10 years ago
should have read: bug 420399 changed the behavior of e4x/extensions/regress-312196.js

also fwiw, this passes both sections on the 1.8.1 branch. the last failure on the 1.8.1 branch was on 2007-08-06.

Flags: wanted1.8.1.x+
(Assignee)

Comment 8

10 years ago
Created attachment 307437 [details] [diff] [review]
v1

This fixes the regression from 1.8.1 branch via extracting the function name from function::name qnames.
Attachment #307437 - Flags: review?(brendan)
Comment on attachment 307437 [details] [diff] [review]
v1

Regression fix we need.

/be
Attachment #307437 - Flags: review?(brendan)
Attachment #307437 - Flags: review+
Attachment #307437 - Flags: approval1.9?
Comment on attachment 307437 [details] [diff] [review]
v1

a1.9=beltzner
Attachment #307437 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 11

10 years ago
I checked in the patch from comment 8 to the trunk:

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1204748113&maxdate=1204748330&who=igor%25mir2.org
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

10 years ago
v from MozillaTest.

/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.49; previous revision: 1.48
Status: RESOLVED → VERIFIED
(Reporter)

Updated

10 years ago
Flags: in-testsuite+
Flags: in-litmus-
(Assignee)

Updated

10 years ago
Depends on: 435546
You need to log in before you can comment on or make changes to this bug.