355467 - <svg:pattern> does not render

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[daniel newton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061001 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061001 Minefield/3.0a1

I have a simple pattern that should stretch the pattern over an elements filled area but it is not rendering at all.

Reproducible: Always

Comment 1

[daniel newton]

Attachment: svg pattern example

Comment 2

[daniel newton]

Attachment: screenshot of svg pattern example in batik

Comment 3

[daniel newton]

Attachment: svg pattern example 2

Comment 4

[daniel newton]

Attachment: screenshot of svg pattern example 2 in opera

Comment 5

[Scooter Morris]

Well, we're clearly not handling patternUnits="objectBoundingBox" right.  We do the right thing in GetPatternRect, but we don't handle it correctly the other places we call GetX(), GetY(), GetHeight(), and GetWidth().   I did a quick hack to fix that up, but I'm still not getting the correct rendering (I think I'm getting some incorrect offsets).  Pattern example 2 is totally messed up in my hacked version (but at least it paints a pattern!).

Comment 6

[tor]

Attachment: partial fix (actually bug 345448)

Does this help any with your patch?  I needed this to fix bug 345448.

Comment 7

[Scooter Morris]

(In reply to comment #6)
> Created an attachment (id=241460) [edit]
> partial fix (actually bug 345448)
> 
> Does this help any with your patch?  I needed this to fix bug 345448.
> 

No, but it certainly changes things.  The pattern is still offset, but now it seems to be even more so.  I'm attaching my patch, can you see what you see?

Comment 8

[Scooter Morris]

Attachment: Quick hack to fixup the objectBoundingBox case

Comment 9

[Robert Longson [:longsonr]]

Example 2 seems to display as desired now. Example 1 does not though.

Comment 10

[Robert Longson [:longsonr]]

I think we are displaying Example 1 correctly. I.e. it should not display anything. To get it to display set patternContentUnits = "objectBoundingBox" on the pattern. 

patternContentUnits is currently not specified and so it defaults to userSpaceOnUse.

Consider the rect in Example 1 for instance which is at x=0, y=250. This references a pattern rect at 0, 0 with height 100. Since we are in user space this means the pattern displays entirely outside the rect because 0 + 100 < 250.

Not sure whether to close this as INVALID based on Example 1 or a duplicate of bug 377263 based on Example 2.