355822 - User profile selection window cropped

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Andrew Hoddinott]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1) Gecko/20061003 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1) Gecko/20061003 Firefox/2.0

The Choose User Profile window is not tall enough, cropping the Start Firefox and Quit buttons.

Reproducible: Always

Steps to Reproduce:
Start Firefox with -ProfileManager

Actual Results:  
See attached image (to follow)


Regression in 2.0RC2, not present in 2.0RC1.
Less pronounced in en-US; the buttons are very close to the bottom edge of the window, but not cropped.
Not present in ja-JP-mac or en-US on PPC Mac OS X Mach-O.

Comment 1

[Andrew Hoddinott]

Attachment: Screen capture of problem

Comment 2

[Steve England [:stevee]]

Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!

Comment 3

[Andrew Hoddinott]

The problem is still present in 2.0.0.4.
- Delete <User>\Application Data\Mozilla\Firefox
- Start Firefox with -ProfileManager
Dialog box is correct size, empty user list extends to bottom of Rename Profile... button.
- Create Profile...
User list expands, extending beyond bottom of Delete Profile... button, but dialog size remains the same, with "Start Firefox" and "Exit" buttons pushed almost beyond the end of the panel.
- Exit
- Start Firefox with -ProfileManager
"Start Firefox" and "Exit" buttons are more visible, but cropped, as originally reported.

Comment 4

[pal-moz]

Attachment: screen shot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090301 Minefield/3.0a8pre ID:2007090301

same with Minefield.
maybe this is a problem with OS(Japanese)?

Comment 5

[pal-moz]

similar one, Bug 248648

Comment 6

[pal-moz]

maybe this will be fixed by the same way as bug 396635 .

Comment 8

[Masahiro YAMADA]

This problem is still reproduced on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008061503
Minefield/3.1a1pre
With Windows XP (Japanese) , with Luna, normal Font.

Comment 9

[Atsushi Sakai]

Attachment: Patch v1.0 [Checkin: Comment 13]

Proposed patch, but not tested because I don't have build environment on Windows.

Can someone test this patch?

Comment 10

[Atsushi Sakai]

This problem can be reproduced also on Linux if small font is used (e.g. change the size of Application font to 6, but this value depends on the font, display resolution setting and so on).

And I've confirmed the Patch v1.0 fixes the problem on Linux.

Comment 11

[Masahiro YAMADA]

Patch v1.0 looks fine on WindowsXP SP3

Comment 12

[Atsushi Sakai]

Comment on attachment 325525 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 13]

When profile manager starts, following action is taken:

1. The size of listitem is computed.
   But the size of icon is not considerd because the icon is not yet loaded at this time.
2. The size of listbox is computed based on the size of listitem.
3. The size of window is determined to fit to the contents including the listbox.
4. The icon is loded.
5. The size of listitem is recomputed using the size of icon.
6. The size of listbox is recomputed based on the new size of listitem.

If 6. is bigger than 2., the button falls down to be cropped.

If the size of icon is available at 1, recomputing of size does not happen and the button is not cropped.
To do so, the size of icon can be specified with CSS.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 325525 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/b839ff0630c6

Comment 14

[Atsushi Sakai]

Comment on attachment 325525 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 13]

Requesting approval for 1.9.1.
The risk is low, because this affects only profile manager, and just specifies icon size.
And it have been baked on mozilla-central for 5 days but no issue is found.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 325525 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 13]

a191=beltzner

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/64a2ee52d1cc

Comment 17

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1b3pre) Gecko/20090115 Shiretoko/3.1b3pre.   Will check this on trunk when b3 builds are out.