[Meta] Update the Modern theme for SeaMonkey 2.0

RESOLVED FIXED

Status

SeaMonkey
Themes
--
enhancement
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Philip Chee, Assigned: AKIHIRO Misaki (a.k.a Kuden))

Tracking

(Depends on: 1 bug, {fixed-seamonkey2.0, modern})

Trunk
fixed-seamonkey2.0, modern
Dependency tree / graph
Bug Flags:
wanted-seamonkey2.0 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(5 attachments, 6 obsolete attachments)

(Reporter)

Description

9 years ago
This is a tracking bug for work on updating the Modern Theme and implementing the missing elements now that trunk has moved to tookkit (e.g. /global/ and /mozapps/).

There is also a thread in the Theme Development forum on the Mozillazine phpBB tracking this work. http://forums.mozillazine.org/viewtopic.php?f=18&t=748735.

Kuden is currently working on /mozapps/
Flags: wanted-seamonkey2?

Updated

9 years ago
Flags: wanted-seamonkey2? → wanted-seamonkey2+
(Reporter)

Updated

9 years ago
Depends on: 432016, 416219
Keywords: modern
Depends on: 458246

Updated

9 years ago
Depends on: 279611
(Reporter)

Comment 1

9 years ago
Created attachment 348743 [details]
/mozapps/

Kuden has finished /mozapps/ and posted a full theme (tkmodern) at http://maguroban.s41.xrea.com/theme/ToolkitModern.jar. I think it's too large to attach here so I'm going to attach only the /mozapps/ sub directory.

Phil
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> Created an attachment (id=348743) [details]
> /mozapps/

At least, these changes are also necessary with  /mozapps/   . 

button.css, textbox.css, wizard.css, toolbarbutton.css,
progressmeter.css, richlistbox.css, notification.css

and 
/global/throbber/
/global/icons/(added new icons)

Comment 3

9 years ago
Note that we don't actually use downloads or handling (though this may change), passwordmgr, places or profile.

Comment 4

9 years ago
The .jar also seems to include updated theming for newsblog and some other pages (ThreeDShadow crept into config.css and netError.css for example...)
Assignee: nobody → spitfire.kuden
(Reporter)

Comment 5

9 years ago
> (ThreeDShadow crept into config.css and netError.css for example...)
Is that good or is that bad?

Comment 6

9 years ago
It's bad that we currently have ThreeDShadow in Modern, yes.

Comment 7

9 years ago
ThreeDShadow is mapped to a system color that varies between platforms. So, it won't be the same on different platforms.

Comment 8

9 years ago
(In reply to comment #4)
> The .jar also seems to include updated theming for newsblog
Oops, that was a bogus diff on my part.

At a quick glance, the change to global/button.css is incorrect, though.

Comment 9

9 years ago
The about:buildconfig changes look nice, except for the outer netError-like border, which I don't think fits, and doesn't really work with about: either.
Created attachment 349042 [details] [diff] [review]
global/config.css

I liked some of your config.css changes:
* use background-color not just background
* #warningBox needs a colour
* ThreeDShadow should be a Modern colour
* #exclam should have a width and height
but not others:
* comments restored
* bracing and CSS properties reverted to file style
* useless and incorrect #configTree margin removed
* #filterRow margin removed, I don't think we need it
What do you think?
Attachment #349042 - Flags: review?(spitfire.kuden)
(Assignee)

Comment 11

9 years ago
(In reply to comment #10)
> Created an attachment (id=349042) [details]
> global/config.css

This looks good.
However, I cannot change the attachment (id=349042)...

Neil, Does mozapps of SeaMonkey Modern need only these?
mozapps/extensions/
mozapps/plugins/
mozapps/update/
mozapps/xpinstall/

(I memorize for mozapps/places/ to have been made by demanding KaiRo.)

I select only files really necessary for mozapps of SeaMonkey Modern.
(Reporter)

Comment 12

9 years ago
I should be filing several dependent bugs for each item as this should be kept as the META or tracking bug.

(In reply to comment #2)
> At least, these changes are also necessary with  /mozapps/   . 

> button.css, textbox.css, wizard.css, toolbarbutton.css,
> progressmeter.css, richlistbox.css, notification.css

> and 
> /global/throbber/
> /global/icons/(added new icons)

(In reply to comment #11)
> However, I cannot change the attachment (id=349042)
(Reporter)

Updated

9 years ago
Blocks: 465924
(Reporter)

Comment 13

9 years ago
I've filed Bug 465924 for work on global. Neil could you copy/move your attachment(s) there?

(In reply to comment #11)
> However, I cannot change the attachment (id=349042)
Neil can we arrange for Kuden to get editbugs?
(Assignee)

Updated

9 years ago
Attachment #349042 - Flags: review+
(Assignee)

Updated

9 years ago
Attachment #349042 - Flags: review?(spitfire.kuden)
(In reply to comment #11)
> Neil, Does mozapps of SeaMonkey Modern need only these?
> mozapps/extensions/
> mozapps/plugins/
> mozapps/update/
> mozapps/xpinstall/
It definitely needs these. It might need some of the others later too.

(In reply to comment #13)
> I've filed Bug 465924 for work on global. Neil could you copy/move your
> attachment(s) there?
Hardly seems worth it for attachment 348042 [details].
Comment on attachment 349042 [details] [diff] [review]
global/config.css

Pushed changeset bbb774695612 to comm-central.
(Reporter)

Updated

9 years ago
Depends on: 355822
(Reporter)

Comment 16

9 years ago
Removing dependency on Bug 355822 for the moment since we are using a forked UI for the profile selection dialog (we use a tree instead of a listbox). Can someone check if this affects us?
No longer depends on: 355822
(Reporter)

Updated

9 years ago
Depends on: 367272
(In reply to comment #16)
> Removing dependency on Bug 355822 for the moment since we are using a forked UI
> for the profile selection dialog (we use a tree instead of a listbox). Can
> someone check if this affects us?
It should have no affect on us at all.
Do we already have a bug for icons in the Error Console (All, Errors, Warnings, Messages, Clear) or is this not desired for Modern?
(Reporter)

Comment 19

9 years ago
> Do we already have a bug for icons in the Error Console (All, Errors, Warnings,
> Messages, Clear) or is this not desired for Modern?

Well traditionally we didn't have icons in the XPFE error console. When we moved to toolkit we picked up the toolkit error console with the fancy toolbar buttons - but only with classic of course (since much of classic comes from toolkit).

I'm the current maintainer of ConsoleĀ² which has icons and customizable toolbars so a current workaround for you is to install this extension.
(In reply to comment #18)
> Do we already have a bug for icons in the Error Console (All, Errors, Warnings,
> Messages, Clear) or is this not desired for Modern?
Well, I don't mind, as long as we can turn them off again ;-)
(Reporter)

Updated

9 years ago
Depends on: 471921
No longer depends on: 458246
(Reporter)

Updated

9 years ago
Depends on: 458246

Updated

9 years ago
Blocks: 477309

Updated

9 years ago
Depends on: 477427
(Reporter)

Updated

9 years ago
No longer blocks: 477309
Depends on: 477710, 477309

Comment 21

9 years ago
From what I heard so far, we'd need some work from someone who can drive the existing work done by Kuden through our review process and into the SeaMonkey tree, which will probably require a number of (smaller) adaptations.
Keywords: helpwanted

Comment 22

9 years ago
Created attachment 367725 [details] [diff] [review]
MozApps from Kuden's Modern Theme
Attachment #367725 - Flags: review?

Comment 23

9 years ago
Created attachment 367726 [details] [diff] [review]
Reporter CSS Changes (from Kuden)
Attachment #367726 - Flags: review?

Comment 24

9 years ago
Created attachment 367727 [details] [diff] [review]
Messenger CSS and Throbber PNG (from Kuden)

Updated

9 years ago
Attachment #367727 - Attachment description: Messenger CSS and Throbber PNG → Messenger CSS and Throbber PNG (from Kuden)
Attachment #367727 - Flags: review?

Updated

9 years ago
Attachment #367726 - Attachment description: Reporter CSS Changes → Reporter CSS Changes (from Kuden)

Comment 25

9 years ago
Created attachment 367728 [details]
Global CSS Changes (Bad Upload)
Attachment #367728 - Flags: review?

Updated

9 years ago
Attachment #367728 - Attachment description: Global CSS Changes → Global CSS Changes (Bad Upload)
Attachment #367728 - Attachment is obsolete: true
Attachment #367728 - Flags: review?

Comment 26

9 years ago
Created attachment 367729 [details] [diff] [review]
Global CSS Changes (from Kuden)

Comment 27

9 years ago
Created attachment 367730 [details] [diff] [review]
Modern Directory's CSS and PNGs (from Kuden)
Attachment #367730 - Flags: review?

Comment 28

9 years ago
I just finished uploading all of the patches from extracting the JAR onto a Comm-Central checkout.  I'll investigate who best to review and if any files were deleted tomorrow.  I'll also upload zip files of the images tomorrow as well. Let me know if there is a preferred way to break up the changes/additions.
One problem is that we want to keep the changes (bug 474807 is one obvious example) to Modern that have been made since the .jar was created.
In fact bug 474807 is a really annoying example as it also need to be applied to the "new" parts to the theme :-(

Comment 31

9 years ago
Comment on attachment 367725 [details] [diff] [review]
MozApps from Kuden's Modern Theme

Benjamin, please direct the review to a specific person, review requests without a target person are usually ignored as nobody feels it's his task to look at them.

Setting them to Neil as he's our "UI tsar" and also knows Modern quite well.
Attachment #367725 - Flags: review? → review?(neil)

Updated

9 years ago
Attachment #367726 - Flags: review? → review?(neil)

Updated

9 years ago
Attachment #367727 - Flags: review? → review?(neil)

Updated

9 years ago
Attachment #367730 - Flags: review? → review?(neil)
Benjamin: Do you plan to work on what Neil said in Comment 29? If you need some help with this, please comment in the bug.

Comment 33

9 years ago
I do plan to work on what Neil said in comment 29.  I am aiming to have anther round of patches ready this week.  Sorry for the delay.

Comment 34

8 years ago
Due to exams and the death of what was a faulty NVIDIA graphics chip, I am not able to get to this until this weekend.   If that is a problem, feel free to take the bug from me.  My planned approach is to start with the patches I created and then add all of the patches made to modern since the theme was created, according to the results of a search for "modern" on http://hg.mozilla.com/comm-central.  Does this seem the best way to do this?  Also, I assume that it is actually preferred that I submit patches on the dependent bugs.  If so, I will do that for the next round of patches.

Updated

8 years ago
Attachment #367725 - Attachment is obsolete: true
Attachment #367725 - Flags: review?(neil)

Updated

8 years ago
Attachment #367730 - Attachment is obsolete: true
Attachment #367730 - Flags: review?(neil)

Updated

8 years ago
Attachment #367729 - Attachment is obsolete: true

Updated

8 years ago
Attachment #367727 - Attachment is obsolete: true
Attachment #367727 - Flags: review?(neil)

Updated

8 years ago
Attachment #367726 - Attachment is obsolete: true
Attachment #367726 - Flags: review?(neil)
(Reporter)

Comment 35

8 years ago
> My planned approach is to start with the patches I
> created and then add all of the patches made to modern since the theme was
> created, according to the results of a search for "modern" on
> http://hg.mozilla.com/comm-central.  Does this seem the best way to do this?

Errr. Nooo. I would recommend instead that you do a manual merge (I think some people use kdiff3, I'm on Windows so I use WinMerge) file by file making sure that you don't override any changes to the theme that were made since Kuden made the modified JAR.

You can use MXR to look at each file, then for each file in the top right corner are links to the HG log. The column on the left in the HG log has a "diff" link for each changeset that tells you what was changed.

> Also, I assume that it is actually preferred that I submit patches on the
> dependent bugs.

Yes that's the way to do it. Also if there doesn't exist a dependent bug for a particular global submodule then by all means file one and make it block this one.

Keep up the good work!
No longer blocks: 465924
Depends on: 465924

Updated

8 years ago
Depends on: 398138

Updated

8 years ago
Depends on: 490277

Updated

8 years ago
Depends on: 493022
(Reporter)

Updated

8 years ago
Depends on: 498153
Ping?
Benjamin: Any update?
(Reporter)

Updated

8 years ago
Attachment #367728 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

8 years ago
No longer depends on: 416219
(Reporter)

Updated

8 years ago
Depends on: 512254
No longer depends on: 432016
Created attachment 405047 [details] [diff] [review]
Fix Modern iconic menus

Steps to reproduce problem:
1. Install an extension that uses iconic menus e.g.
   Versions (https://addons.mozilla.org/addon/3830)
2. Switch to the Modern theme
3. Note that the arrow for the iconic menu does not line up. This is because
   the XBL for iconic menus includes pack="center" but not for ordinary menus.

The problem does not occur in the Classic theme on either Windows or Linux because both of those themes use -moz-appearance on the containing box.
The problem is less obvious with Pinstripe because of its native menus.
OS/2 also fixed the problem by adding some padding to its containing box.
Attachment #405047 - Flags: review?(iann_bugzilla)
Created attachment 405050 [details] [diff] [review]
Alternative fix as suggested by Dao

Dao suggested increasing the margin and reducing the width instead.
Attachment #405050 - Flags: review?(iann_bugzilla)

Comment 40

8 years ago
Comment on attachment 405050 [details] [diff] [review]
Alternative fix as suggested by Dao

I think I prefer this one as the actual image is 4px wide
Attachment #405050 - Flags: review?(iann_bugzilla) → review+

Updated

8 years ago
Attachment #405047 - Flags: review?(iann_bugzilla)

Updated

8 years ago
Attachment #405050 - Flags: approval-seamonkey2.0+

Comment 41

8 years ago
Let's get this off the "approved but not fixed" radar for 2.0 - I wonder if we should mark it fixed as a whole...
Keywords: fixed-seamonkey2.0

Comment 42

8 years ago
oops, apparently there is an actual patch here that was not checked in, so it correctly shows on the radar.
I hate intermingling trackers with actual patches on the bug...
Keywords: fixed-seamonkey2.0

Updated

8 years ago
Depends on: 521383
Pushed changeset 9bad4209e8aa to mozilla-central.

I know this is really a tracking bug, but I'm going to mark it fixed anyway.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: fixed-seamonkey2.0
Resolution: --- → FIXED
(Reporter)

Updated

8 years ago
Keywords: helpwanted
Created attachment 406018 [details] [diff] [review]
Another 1-liner

Sorry for being too lazy to file separate bugs for all these.

This changes the display of password requests to a nice "lock" icon; by comparison Linux builds already use a "key" instead of a question mark.
Attachment #406018 - Flags: review?(iann_bugzilla)

Updated

8 years ago
Attachment #406018 - Flags: review?(iann_bugzilla)
Attachment #406018 - Flags: review+
Attachment #406018 - Flags: approval-seamonkey2.0+
Comment on attachment 406018 [details] [diff] [review]
Another 1-liner

Pushed changeset 98c8cbfc4b23 to comm-central.
You need to log in before you can comment on or make changes to this bug.