According to TB there are few crashes @ nsFormFillController::OnTextEntered. Possible patch coming.
Component: Form Manager → Satchel
Product: Firefox → Toolkit
QA Contact: form.manager → satchel
Created attachment 241703 [details] [diff] [review] possible patch Bryner, since ::OnTextEntered is mainly you code, could you review. This should fix the possible crash when ownerDocument is null or when mFocusedInput is null (if that is possible). Other change is to set the return value to something. That is based on this comment: http://lxr.mozilla.org/seamonkey/source/toolkit/components/autocomplete/public/nsIAutoCompleteInput.idl#149 but it shouldn't actually change the functionality because the return value isn't actually handled: http://lxr.mozilla.org/seamonkey/source/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp#1123
Attachment #241703 - Flags: first-review?(bryner)
Comment on attachment 241703 [details] [diff] [review] possible patch Should not be possible for mFocusedInput to be null, but better not to crash. Similarly, I don't know how a text input could be without an ownerDocument, but bulletproofing is fine.
Attachment #241703 - Flags: first-review?(bryner) → first-review+
ownerDocument is *not* guaranteed to be non-null. Basically if something keeps a reference to a node, but document is deleted, then ownerDocument is null.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Is this something worth of the branch?
Apparently yes. There are some crashes also on 1.8.
Attachment #241703 - Flags: approval220.127.116.11?
Smaug, is there a reason you requested approval for 18.104.22.168 and not 22.214.171.124?
(In reply to comment #8) > Smaug, is there a reason you requested approval for 126.96.36.199 and not 188.8.131.52? He did ask for approval184.108.40.206, see bug activity. The flag was renamed to approval220.127.116.11 in preparation for a quicker than usual 18.104.22.168 release.
This became the run-away top crash in FF22.214.171.124 (more crashes than old stand-by 0x00000000 even), and don't appear on the lists for prior versions (with admitedly small populations remaining on older versions). Was this crash tickled by the password manager changes? Seems unlikely, but I don't think 126.96.36.199 made any other form-related changes.
Severity: normal → critical
Flags: blocking188.8.131.52? → blocking184.108.40.206+
Keywords: crash, topcrash
Duplicate of this bug: 374785
Comment on attachment 241703 [details] [diff] [review] possible patch approved for 220.127.116.11, a=dveditz for release-drivers
Attachment #241703 - Flags: approval18.104.22.168? → approval22.214.171.124+
(In reply to comment #11) > Was this crash tickled by the password manager changes? Seems unlikely, > but I don't think 126.96.36.199 made any other form-related changes. bug 286933 was fixed in 188.8.131.52 and seems more directly relevant
I have those annoying crashs almost every day in forums.... when will it be fixed in firefox2 ?
Andreas, in the next security update, you can test it yourself, see: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/184.108.40.206-candidates/rc1/
v.fixed on 1.8 branch and Trunk based on the latest Talkback data. Let's keep a close eye on topcrash reports for 220.127.116.11 after the release to make sure this is gone with no regressions.
Status: RESOLVED → VERIFIED
Keywords: fixed18.104.22.168 → verified22.214.171.124
Component: Satchel → Form Manager
Crash Signature: [@ nsFormFillController::OnTextEntered]
You need to log in before you can comment on or make changes to this bug.