Closed
Bug 356078
Opened 19 years ago
Closed 19 years ago
Submenus are always enabled in cocoa widget menus
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: asaf, Assigned: jaas)
References
Details
Attachments
(1 file)
|
6.22 KB,
patch
|
asaf
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Submenus are always enabled in cocoa widget menus. That is, even when the disabled attribute is set.
Testcase: View->Toolbars when no window is open.
|
Reporter | |
Updated•19 years ago
|
Flags: blocking1.9?
Attachment #241810 -
Flags: review?(mano)
In that patch I changed some null values to "nil" when the comparison is against a cocoa object pointer. I did that because "nil" is what is normally used for Cocoa objects, and its a nice reminder of what you're dealing with.
|
|
Reporter | |
Comment 3•19 years ago
|
||
Comment on attachment 241810 [details] [diff] [review]
fix v1.0
r=mano
Attachment #241810 -
Flags: review?(mano) → review+
Attachment #241810 -
Flags: superreview?(mikepinkerton)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 241810 [details] [diff] [review]
fix v1.0
sr=pink
Attachment #241810 -
Flags: superreview?(mikepinkerton) → superreview+
fixed on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•19 years ago
|
Flags: blocking1.9?
|
||
Comment 6•19 years ago
|
||
*** Bug 355800 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•