356100 - Location/Search split view doesn't enforce min widths during window resize

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Stuart Morgan]

If the window is resized, the URL bar can end up smaller than the intended minimum, and in the extreme case the splitter can actually move so far left it's no longer visible.

Comment 1

[Stuart Morgan]

Attachment: fix

Enforces URL field min width on widget resize. Also fixes bug 346137, since I didn't want to wait for that to land to fix this, and the patches can't be separated.

Comment 2

[Nick Kreeger]

Comment on attachment 241777 [details] [diff] [review]
fix

+      if (searchBarWidth <= 0.00001)
+        searchBarWidth = kDefaultSearchBarWidth;

Looks good to me, my only suggestion would be to make 0.00001 a constant since you use it in two places.

r=me

Comment 3

[Stuart Morgan]

Attachment: r=kreeger version

Adds a constant, and makes it larger since I realized the value I was using was borderline questionable for values in the hundreds, and we don't need fine-grained precision.  Also adds a fabsf which should have been there in the first place.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 241845 [details] [diff] [review]
r=kreeger version

sr=pink

Comment 5

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.