Location/Search split view doesn't enforce min widths during window resize

RESOLVED FIXED

Status

Camino Graveyard
Toolbars & Menus
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.68 KB, patch
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
If the window is resized, the URL bar can end up smaller than the intended minimum, and in the extreme case the splitter can actually move so far left it's no longer visible.
(Assignee)

Comment 1

11 years ago
Created attachment 241777 [details] [diff] [review]
fix

Enforces URL field min width on widget resize. Also fixes bug 346137, since I didn't want to wait for that to land to fix this, and the patches can't be separated.
Attachment #241777 - Flags: review?(nick.kreeger)
Blocks: 346137

Comment 2

11 years ago
Comment on attachment 241777 [details] [diff] [review]
fix

+      if (searchBarWidth <= 0.00001)
+        searchBarWidth = kDefaultSearchBarWidth;

Looks good to me, my only suggestion would be to make 0.00001 a constant since you use it in two places.

r=me
Attachment #241777 - Flags: review?(nick.kreeger) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 241845 [details] [diff] [review]
r=kreeger version

Adds a constant, and makes it larger since I realized the value I was using was borderline questionable for values in the hundreds, and we don't need fine-grained precision.  Also adds a fabsf which should have been there in the first place.
Attachment #241777 - Attachment is obsolete: true
Attachment #241845 - Flags: superreview?(mikepinkerton)
Comment on attachment 241845 [details] [diff] [review]
r=kreeger version

sr=pink
Attachment #241845 - Flags: superreview?(mikepinkerton) → superreview+

Comment 5

11 years ago
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

Updated

11 years ago
Keywords: fixed1.8.1.1

Updated

11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.