356247 - Round-trip bracing change with "let {} = [1];" in a loop

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

(1) With for..let as the outer loop

js> f = function() { for(let x in []) let {} = [1]; }
function () {
    for (let x in [])
        let [] = [1];
}

js> eval("" + f)
function () {
    for (let x in []) {
        let [] = [1];
    }
}


(2) With while as the outer loop

js> f = function() { while(0) let {} = [1]; }         
function () {
    while (0)
        let [] = [1];
}

js> eval("" + f)                              
function () {
    while (0) {
        let [] = [1];
    }
}

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk:

Checking in jsopcode.c;
/cvsroot/mozilla/js/src/jsopcode.c,v  <--  jsopcode.c
new revision: 3.249; previous revision: 3.248
done

/be

Comment 4

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_7/decompilation/regress-356247.js,v  <--  regress-356247.js
initial revision: 1.1

Comment 5

[Bob Clary [:bc] (inactive)]

I'm getting a syntax error during the compile stage of the source comparison in the browser but not the shell.
<http://test.bclary.com/tests/mozilla.org/js/js-test-driver-standards.html?test=js1_7/decompilation/regress-356247.js;language=type;text/javascript;version=1.7>

and still getting the extra braces on the evald comparison in the shell.

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to comment #5)

> 
> and still getting the extra braces on the evald comparison in the shell.
> 

ignore this, was using an older version of the shell accidentially. sorry. but the syntax error in the browser remains.

Comment 7

[Bob Clary [:bc] (inactive)]

deal with anon fun
/cvsroot/mozilla/js/tests/js1_7/decompilation/regress-356247.js,v  <--  regress-356247.js
new revision: 1.2; previous revision: 1.1

test passes now, ignore me.

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.