356267 - Extension components not excluded by "chrome" filter

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[James Ross]

The Venkman code to exclude "chrome" files is Mozilla 1.2 code. It just excludes anything in the same directory as venkman-service.js. It's time to fix that. :)

Comment 1

[James Ross]

Attachment: Make components into a dir list and exclude all

This also fixes the chrome filter to work correctly (toggling after starting). Will attach -w diff for review.

Comment 2

[James Ross]

Attachment: diff -w version of previous attachment

Comment 3

[:Gijs (he/him)]

Comment on attachment 277137 [details] [diff] [review]
diff -w version of previous attachment

r=me, but:

* I'd prefer to hold off on checking this in if we can find a timely solution to bug 358286.
* The back of my mind is wondering whether it makes any sense at all to cache the "is this file chrome or a component" info somewhere - given the component dir thing is O(n*m) (for n JS/HTML/XUL files and m component dirs)

Comment 5

[:Gijs (he/him)]

Attachment: Updated version of patch

James, the file: stuff is fixed in current HG Vnk now. I attempted to un-bitrot your patch, but I ran into some issues with rec.show() (in venkman-views:

Internal error processing hook “scripts:chrome-filter”.
TypeError: rec.show is not a function @ <chrome://venkman/content/venkman-views.js> 1079

Any clue what that's about?

Comment 6

[James Ross]

It should be rec.unHide().

Comment 7

[:Gijs (he/him)]

(In reply to comment #6)
> It should be rec.unHide().

Great, that works. I've commented out the if ("parentRecord" in rec) check, too, as that meant changing back from not showing to showing them didn't work. I tested that change with expanded scripts, seemed to all be just fine, so committed that. Thanks a lot!

(changeset:   654:b63d7bb88a0f)

Comment 8

[:Gijs (he/him)]

Of course, I didn't take into account that Fx 4 would nuke this out of orbit because ComsD and friends have been removed, so these directory service calls throw exceptions instead. Great. Patch in a second.

Comment 9

[:Gijs (he/him)]

Attachment: Fix detection on trunk / Moz 2.0

Comment 10

[Karsten Düsterloh]

Comment on attachment 467062 [details] [diff] [review]
Fix detection on trunk / Moz 2.0

r=me with bracing style fixed.

Comment 11

[:Gijs (he/him)]

(In reply to comment #10)
> Comment on attachment 467062 [details] [diff] [review]
> Fix detection on trunk / Moz 2.0
> 
> r=me with bracing style fixed.

Checked in with braces fixed, changeset 661:db6bde58e48d