356341 - when opening a group of bookmarks (and livemarks) don't stop on invalid scheme

Status: RESOLVED DUPLICATE of bug 356571

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

when opening a group of bookmarks (and livemarks) don't stop on invalid scheme

see bug #356321 for how this can happen in the real world.

a way to reproduce it is to have a bm folder with 3 bookmarks, and you can set the   2nd bm url to be foo:bar, and we'll fail when trying to open the group of bookmarks as tabs and we'll stop opening bookmarks as tabs.

I'll attach as screen shot of the problem.

maybe it would be good to move this error into the content, like you see when the server is not found?  (try loading http://www.adsfda.sdfs.cxxx/)

Comment 1

[(not reading, please use [e-mail] instead)]

see also bug #260918

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> when opening a group of bookmarks (and livemarks) don't stop on invalid scheme

I thought this was already covered by http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.716&mark=1603,1604#1593 , but I guess bookmarks doesn't use that function?

> maybe it would be good to move this error into the content, like you see when
> the server is not found?  (try loading http://www.adsfda.sdfs.cxxx/)

That used to happen, but had to be reverted due to bug 307027 (see bug 307027 comment 6).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> I thought this was already covered by
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.716&mark=1603,1604#1593
> , but I guess bookmarks doesn't use that function?

Oh, I see why this no longer works - before bug 308396 loadOneOrMoreURIs loaded each tab itself, and wrapped the loadTab call in a try/catch, but now we call loadTabs, which doesn't catch individual exceptions when it loops through the tabs to add.

(compare with http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.554&mark=1461,1462#1458)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Of course, I just realized that that function is only used for homepages, so isn't exactly relevant to this bug. I'll file another bug I guess, sorry for the bugspam!

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I filed bug 356571.

Comment 7

[Marco Bonardo [:mak]]

instead we are now using loadTabs in Places, so i suppose now these bugs are the same.