356441 - When customizing toolbar, can't drop tools. (Toolbar won't change.)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[David Koppelman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061012 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061012 Minefield/3.0a1

Can't drop new tools onto toolbar or drag existing ones off toolbar using customize.

Reproducible: Always

Steps to Reproduce:
1. Use context menu over icon to open customize dialog.
2. Drag a new tool from toolbox to toolbar and release.
3.

Actual Results:  
Circle/slash icon remains, even when hovering over what should be a good spot. Tool does not appear in toolbar after releasig button.

Expected Results:  
Tool should appear at drop point.

Comment 1

[David Koppelman]

I learned of the bug from Destian on this post http://forums.mozillazine.org/viewtopic.php?p=2535867#2535867

Comment 2

[David Koppelman]

The problem has occurred with and without a fresh profile. 

Comment 3

[Destian]

I checked yesterday's build and it did not work. After that I jumped back to the 6th and it works fine, so...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061006 Minefield/3.0a1 WORKS
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061011 Minefield/3.0a1 DOES NOT WORK

The regression is somewhere in between those two dates.

Comment 4

[Brian Polidoro]

The error from the console is:
Error: gBrowser is not defined
Source File: chrome://reporter/content/reporterOverlay.js
Line: 74

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> The error from the console is:
> Error: gBrowser is not defined
> Source File: chrome://reporter/content/reporterOverlay.js
> Line: 74

That error isn't relevant, it's harmless.

Comment 6

[u88484]

(In reply to comment #4)
> The error from the console is:
> Error: gBrowser is not defined
> Source File: chrome://reporter/content/reporterOverlay.js
> Line: 74
> 

Not related, that has always showed up as soon as you open the customize window.

Comment 7

[Brian Polidoro]

The thought did cross my mind to search bugzilla for gbrowser.  But left after searching for customiz*. :)
Bug 313359

Comment 8

[Destian]

All right, I narrowed it down:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061010
Minefield/3.0a1 DOES WORK

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061011
Minefield/3.0a1 DOES NOT WORK

...so the regression takes place in the Oct 11th nightly.

Comment 9

[aja+bugzilla]

(In reply to comment #5)
> (In reply to comment #4)
> > The error from the console is:
> > Error: gBrowser is not defined
> > Source File: chrome://reporter/content/reporterOverlay.js
> > Line: 74
> 
> That error isn't relevant, it's harmless.
> 
Obviously, this is the same thing I discussed with you the other night on IRC.

Comment 10

[Brian Polidoro]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-10+04%3A00%3A00&maxdate=2006-10-11+04%3A00%3A00&cvsroot=%2Fcvsroot
It looks like 191400.  There's also a drag and drop regression in Thunderbird.  

Comment 11

[aja+bugzilla]

(In reply to comment #8)
> All right, I narrowed it down:
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061010
> Minefield/3.0a1 DOES WORK
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061011
> Minefield/3.0a1 DOES NOT WORK
> 
> ...so the regression takes place in the Oct 11th nightly.
> 

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-10&maxdate=2006-10-11&cvsroot=%2Fcvsroot

Posting following per gavin's request, for his followup: 

I'd suspect bug 191400 checkin within the above regression range. (it has also apparently caused TBird/mailnews regression bug 356429.

Comment 12

[David Koppelman]

(In reply to comment #10)
> http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-10+04%3A00%3A00&maxdate=2006-10-11+04%3A00%3A00&cvsroot=%2Fcvsroot
> It looks like 191400.  There's also a drag and drop regression in Thunderbird.  
> 

That provides an easy workaround: Hold down the shift key while dragging.

Comment 13

[aja+bugzilla]

> 
> That provides an easy workaround: Hold down the shift key while dragging.
> 
Yep, that works for me!

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Fixed by the backout of bug 191400.

Comment 15

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** Bug 356950 has been marked as a duplicate of this bug. ***