Closed
Bug 313359
Opened 21 years ago
Closed 20 years ago
"gBrowser is not defined" in reporterOverlay.js
Categories
(Other Applications Graveyard :: Reporter, defect, P3)
Other Applications Graveyard
Reporter
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha
People
(Reporter: zeniko, Assigned: Mook)
References
()
Details
Attachments
(2 files)
|
700 bytes,
patch
|
raccettura
:
review+
|
Details | Diff | Splinter Review |
|
1.19 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051021 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051021 Firefox/1.5
Error: gBrowser is not defined
Source file: chrome://reporter/content/reporterOverlay.js
Line: 74
Reproducible: Always
Steps to Reproduce:
1. Customize any toolbar
2. Have a look at the JavaScript Console
Actual Results:
The above mentioned error was thrown.
Expected Results:
No error (customizing toolbars shouldn't have much to do with Reporter anyway).
Comment 1•21 years ago
|
||
gavin: looks like something you did in bug 294673. Can you take a look at this.
Comment 2•21 years ago
|
||
Ugh, I didn't realize the same overlay was used for the customize toolbar dialog.
Assignee: robert → gavin.sharp
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•21 years ago
|
OS: Windows XP → All
Hardware: PC → All
Comment 3•21 years ago
|
||
Best trunk fix is probably to split the overlays instead of trying to use one
for both, a branch fix would be to just add an if (gBrowser). This shouldn't
affect behavior in any way, so unless it's proven that it does, I don't think
this needs fixing on the branch.
Status: NEW → ASSIGNED
Comment 4•21 years ago
|
||
Agreed.
In a perfect world, we can have just one overlay... but I agree with your fix.
This definately isn't that critical as this isn't the first place in the source
code where such an error has been thrown. ;-)
Updated•21 years ago
|
Priority: -- → P3
Target Milestone: --- → mozilla1.9alpha
Version: unspecified → Trunk
Comment 5•21 years ago
|
||
On second though, I think just checking gBrowser is simpler and works just as well, I don't really see the advantage of seperating the overlays. Robert, what do you think?
Comment 6•21 years ago
|
||
I think separating the overlay's creates a gaint pain in the butt. I'd rather not fork anything if we don't really need to.
I don't see a disadvantage to using if (gBrowser).
Comment 8•21 years ago
|
||
*** Bug 316161 has been marked as a duplicate of this bug. ***
Comment 9•21 years ago
|
||
Comment on attachment 202430 [details] [diff] [review]
patch
r=me
Attachment #202430 -
Flags: review?(robert) → review+
Comment 10•21 years ago
|
||
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.js;
new revision: 1.6;
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 11•20 years ago
|
||
This seems to have regressed again, Bug 324345
Comment 12•20 years ago
|
||
*** Bug 324345 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 13•20 years ago
|
||
Just noticed this behaviour, CCing me.
| Assignee | ||
Comment 14•20 years ago
|
||
Attachment #242504 -
Flags: review?
Attachment #242504 -
Flags: review? → review?(gavin.sharp)
Comment 15•20 years ago
|
||
Comment on attachment 242504 [details] [diff] [review]
one line patch to check typeOf
I prefer |typeof(gBrowser) != "undefined"| :)
Attachment #242504 -
Flags: review?(gavin.sharp) → review+
Updated•20 years ago
|
Whiteboard: [checkin needed]
Updated•20 years ago
|
Assignee: gavin.sharp → mook.moz+sites.org.mozilla.bugzilla
Status: REOPENED → NEW
Comment 16•20 years ago
|
||
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.js 1.8
Status: NEW → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Comment 18•19 years ago
|
||
Could this be applied to Firefox 2 (branch 1.8.1.x)
Updated•8 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•