356579 - remove tr-tdk search plugin on update

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Axel Hecht [:Pike]]

As pointed out in bug 354576, the tr-tdk search plugin shipped with turkish versions of 1.5 is broken due to an incompatible site change, and can't be resurrected.

Updates should remove the plugin, and thus, we should add the two files to removed-files.in.

Patch coming up.

Comment 1

[Axel Hecht [:Pike]]

Attachment: l10n part, don't ship tr-tdk on 1.5.0.x

Comment 2

[Axel Hecht [:Pike]]

Attachment: installer part, remove tr-tdk on update

The second patch should get rid of the tr-tdk plugins for existing installs, just like we did with dictionary.com.

Comment 3

[Axel Hecht [:Pike]]

We should take this bug instead of bug 354576, if this get's plussed, minus the other.

Comment 4

[Daniel Veditz [:dveditz]]

This is the 1.8.0 branch version of bug 354576, moving blocking flag here.

Comment 5

[Ahmet Serkan Tıratacı]

(In reply to comment #1)
> Created an attachment (id=242189) [edit]
> l10n part, don't ship tr-tdk on 1.5.0.x
> 

This one is OK: +

I can't set flag + as I'm told by Bugzilla that I'm not authorised.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 242189 [details] [diff] [review]
l10n part, don't ship tr-tdk on 1.5.0.x

marking review by aserkant (note, I fixed your bugzilla privs, too).

Requesting approval for 1.8.0.8

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 242189 [details] [diff] [review]
l10n part, don't ship tr-tdk on 1.5.0.x

approved for 1.8.0 branch, a=dveditz

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 242191 [details] [diff] [review]
installer part, remove tr-tdk on update

approved for 1.8.0 branch, a=dveditz

Comment 9

[Axel Hecht [:Pike]]

Checked in.

I'm leaving the bug open for investigating how things should behave on the 1.8 branch wrt updates from the 1.5 tree to the 2.0 one.

Comment 10

[Axel Hecht [:Pike]]

This seems to have been fixed allright by now.