remove tr-tdk search plugin on update

RESOLVED FIXED

Status

()

Firefox
Installer
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

({fixed1.8.0.8})

1.5.0.x Branch
fixed1.8.0.8
Points:
---
Bug Flags:
blocking1.8.0.8 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
As pointed out in bug 354576, the tr-tdk search plugin shipped with turkish versions of 1.5 is broken due to an incompatible site change, and can't be resurrected.

Updates should remove the plugin, and thus, we should add the two files to removed-files.in.

Patch coming up.
(Assignee)

Comment 1

11 years ago
Created attachment 242189 [details] [diff] [review]
l10n part, don't ship tr-tdk on 1.5.0.x
Attachment #242189 - Flags: review?(aserkant)
(Assignee)

Comment 2

11 years ago
Created attachment 242191 [details] [diff] [review]
installer part, remove tr-tdk on update

The second patch should get rid of the tr-tdk plugins for existing installs, just like we did with dictionary.com.
Attachment #242191 - Flags: review?(benjamin)
Attachment #242191 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

11 years ago
We should take this bug instead of bug 354576, if this get's plussed, minus the other.
Flags: blocking1.8.0.8?
This is the 1.8.0 branch version of bug 354576, moving blocking flag here.
Flags: blocking1.8.0.8? → blocking1.8.0.8+
(In reply to comment #1)
> Created an attachment (id=242189) [edit]
> l10n part, don't ship tr-tdk on 1.5.0.x
> 

This one is OK: +

I can't set flag + as I'm told by Bugzilla that I'm not authorised.
(Assignee)

Comment 6

11 years ago
Comment on attachment 242189 [details] [diff] [review]
l10n part, don't ship tr-tdk on 1.5.0.x

marking review by aserkant (note, I fixed your bugzilla privs, too).

Requesting approval for 1.8.0.8
Attachment #242189 - Flags: review?(aserkant)
Attachment #242189 - Flags: review+
Attachment #242189 - Flags: approval1.8.0.8?
(Assignee)

Updated

11 years ago
Attachment #242191 - Flags: approval1.8.0.8?
Comment on attachment 242189 [details] [diff] [review]
l10n part, don't ship tr-tdk on 1.5.0.x

approved for 1.8.0 branch, a=dveditz
Attachment #242189 - Flags: approval1.8.0.8? → approval1.8.0.8+
Comment on attachment 242191 [details] [diff] [review]
installer part, remove tr-tdk on update

approved for 1.8.0 branch, a=dveditz
Attachment #242191 - Flags: approval1.8.0.8? → approval1.8.0.8+
(Assignee)

Comment 9

11 years ago
Checked in.

I'm leaving the bug open for investigating how things should behave on the 1.8 branch wrt updates from the 1.5 tree to the 2.0 one.
Keywords: fixed1.8.0.8
(Assignee)

Comment 10

8 years ago
This seems to have been fixed allright by now.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.