354576 - Dump TDK search engine from Turkish Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Ahmet Serkan Tıratacı]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1) Gecko/20060918 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1) Gecko/20060918 Firefox/2.0

Approved TDK search engine (bug 348831) for Turkish Firefox 2 no longer works.

After failure, we realised that TDK has changed the site infrastructure unexpectedly. It was OK last week or so. They are using Visual Basic for this search, as can be seen from source code at [1].

Currently "template" variable in tr-tdk.xml [2] is http://tdk.gov.tr/tdksozluk/sozbul.asp? and it can be replaced with http://tdk.gov.tr/TR/sozbul.ASPX?F6E10F8892433CFFAAF6AA849816B2EF05A79F75456518CA&Kelime= to get the search plugin work again.

However, using random-looking F6E10F8892433CFFAAF6AA849816B2EF05A79F75456518CA parameter (or whatever) doesn't seem to be reliable to me.

So, we propose to pull tr-tdk.xml from Turkish Firefox 2.

[1] http://tdk.gov.tr/TR/SozBul.aspx?F6E10F8892433CFFAAF6AA849816B2EF05A79F75456518CA
[2] http://lxr.mozilla.org/l10n-mozilla1.8/source/tr/browser/searchplugins/tr-tdk.xml

Reproducible: Always

Steps to Reproduce:
To reproduce failure

1. Download Firefox 2 RC1 in Turkish.
2. Try to search with TDK
Actual Results:  
"Page cannot be found" error page.

Expected Results:  
Detailed Turkish meaning of the search term.

Comment 1

[Axel Hecht [:Pike]]

Yep, this looks technically not feasible. I tried to just remove the key from the query URL, which directs me to the home again. And the key changes per session, too, which may raise privacy questions.

Please attach a patch to get this removed. Or I could do that as bustage fix.

Yikes, how can someone design a website like that :-(.

Comment 2

[Ahmet Serkan Tıratacı]

(In reply to comment #1)
...
> Please attach a patch to get this removed. Or I could do that as bustage fix.

We'd prefer a fix on your part. Because creating right patches for file removal and list.txt, getting approval and applying patch succesfully would take much more than what you would do.

> Yikes, how can someone design a website like that :-(.

Yes, they really suck. :-S

Comment 3

[Axel Hecht [:Pike]]

Attachment: patch for reference, remove tr-tdk.xml

[tr] removal of broken search plugin approved for RC2. Site changed incompatibly.

Taking this bug, too.

Comment 4

[Axel Hecht [:Pike]]

Patch checked in on the MOZILLA_1_8_BRANCH, no appicable on the trunk.

Should we try to get this done on the MOZILLA_1_8_0_BRANCH, too?

Comment 5

[Ahmet Serkan Tıratacı]

Yeah. It's a good idea to remove it from MOZILLA_1_8_0_BRANCH too. It works the same way tr-tdk.xml does:

http://lxr.mozilla.org/l10n-mozilla1.8.0/source/tr/browser/searchplugins/tr-tdk.src?raw=1

Comment 6

[Daniel Veditz [:dveditz]]

If you could find a way to "fix" it we could update it and fix current users. If you simply remove it from the distribution existing users who upgrade will still have the broken file. At least in 1.5.0.7, not sure if the new 2.0 search works quite the same way.

Hm, maybe we could remove the broken file in the update and install files... That'd require custom hacking the tr installs though, we're not really set up to do that.

Comment 7

[Ahmet Serkan Tıratacı]

What if a new TDK search plugin is created for MOZILLA_1_8_0_BRANCH that takes users to TDK homepage at http://tdk.gov.tr regardless of search term? This would avoid us from trying to find a new solution again and again when TDK changes its site infrastructure every time in future. Users taken to TDK homepage can go through TDK menus and find the query page.

Comment 8

[Axel Hecht [:Pike]]

Did we ever get an answer on our contact request from bug 348831?

Comment 9

[Ahmet Serkan Tıratacı]

No, we haven't been replied.

Comment 10

[Daniel Veditz [:dveditz]]

I doubt this is a "blocker" for 1.8.0.8, but we'll happily approve an appropriate patch if you get one (attachment 240464 [details] [diff] [review] appears specific to 1.8.1). Marking blocking just so we keep track of it, but it'll be one of the first things cut when we get down to the wire.

Comment 11

[Mic Berman]

re comment #8
getting a reply would be great. might help us on the technical issues as well.
just a note of clarification from BD - TDK is good to go as it was shipped in 1.5 so we have no issues with shipping again
thanks
mic

Comment 12

[Ahmet Serkan Tıratacı]

I've recently read at http://sozluk.sourtimes.org/show.asp?id=9923848 that someone got a response from TDK via email after waiting for two months. :-\

I emailed them on Sep 11, 2006, and no answer yet.

Comment 13

[Ahmet Serkan Tıratacı]

Axel, can I or you mark this bug as FIXED not to block Turkish Firefox 2 release?

We can continue to discuss the problem for MOZILLA_1_8_0_BRANCH later here or open a new bug for that.

Comment 14

[Daniel Veditz [:dveditz]]

(In reply to comment #13)
> We can continue to discuss the problem for MOZILLA_1_8_0_BRANCH later here or
> open a new bug for that.

Please keep it here.

We need either a 1.8.0-equivalent patch to remove this, an alternate search engine, or decide we don't care about this in 1.8.0.x.  Time is running out, 1.8.0.8 will be released roughly simultaneously with Firefox 2 (perhaps a week later).

Comment 15

[Ahmet Serkan Tıratacı]

What I want is to close this bug ASAP not to block Firefox 2 in Turkish.

IMHO, we had better care about this for MOZILLA_1_8_0_BRANCH, because there will be lots of people using Firefox 1.5.0.x even after Firefox 2 is relased.

My suggestion is that a new TDK search plugin is created for MOZILLA_1_8_0_BRANCH that takes users to TDK homepage at http://tdk.gov.tr regardless of search term. Then at least people can reach TDK and query page by themselves instead of seing "Page not found" error that we currently see.

Axel?

Comment 16

[Ahmet Serkan Tıratacı]

Attachment: proposed solution for TDK search engine

This patch shows how my proposal for MOZILLA_1_8_0_BRANCH is possible. User is taken to tdk.gov.tr regardless of query.

Please review this, or let's leave everything unchanged.

I really want this bug to be closed ASAP not to block Firefox 2.

Comment 17

[Axel Hecht [:Pike]]

Comment on attachment 242117 [details] [diff] [review]
proposed solution for TDK search engine

Nah, that's not what I want. We should just treat tr-tdk like we treat dictionary, and remove it.

I'll come up with a patch.

Comment 18

[Axel Hecht [:Pike]]

I filed bug 356579 on fixing the issue for existing users on update, I think we should unblock this bug. Dan?

Comment 19

[Daniel Veditz [:dveditz]]

For the 1.8.0 branch this bug has been superseded by bug 356579, and a branch-appropriate equivalent of attachment 240464 [details] [diff] [review] has been incorporated into that bug. (the patch in this bug removes the .xml plugin, 1.8.0 used the Sherlock .src file).  Unblocking.

Can this bug be resolved FIXED now, or is it still open to make sure this lands on the trunk?

Comment 20

[Ahmet Serkan Tıratacı]

Marking FIXED.

Daniel, we don't have Turkish builds on the trunk.