356650 - Cleanup composer_help

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text

1) Fix some errors found by Rafal Likus
2) Consistent use of colons for UI elements
3) 80-col formatting

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Complete patch

Comment 2

[Ian Neal]

Comment on attachment 242263 [details] [diff] [review]
Complete patch

>Index: suite/locales/en-US/chrome/common/help/composer_help.xhtml
>===================================================================
>@@ -1087,8 +1147,6 @@
>   width, spacing, and text alignment. If you are not currently viewing
>   the Image Properties dialog box, follow these steps:</p>
> 
>-<p>To edit the properties for a selected image:</p>
>-
Did you intend to remove this?
> <ol>
>   <li>Double-click the image, or select it and click the Image button
>     <img src="images/image.gif" width="23" height="25" alt="" /> on the toolbar
>@@ -1107,18 +1165,14 @@
> 
>         <p>Unchecking this box causes Composer to convert the URL to a full
>           (absolute) URL. You typically use absolute URLs when linking to
>-          images on other web servers (not stored locally on your hard disk).</p>
>+          images on other web servers (not stored locally on your hard
>+          disk).</p>
> 
>         <p>If you have never saved or published the page, you must first save
>           the page in order to enable this checkbox. (This checkbox is not
>           available if you open the Image Properties dialog box in a message
>           compose window.)</p>
>       </li>
>-      <li><strong>Attach this image to the message</strong>: If checked,
>-        the image is attached to the message you are sending. If unchecked, a
>-        link to the image location is inserted instead. (This checkbox is only
>-        available if you open the Image Properties dialog box in a message
>-        compose window.)</li>
I think you did not intend to remove this, your patch appears to be bit-rotted.

>@@ -1392,14 +1458,8 @@
>           on other web servers (not stored locally on your hard disk).</p>
> 
>         <p>If you have unsaved changes, you must first save the page in order
>-          to enable this checkbox. (This checkbox is not available if you open
>-          the Link Properties dialog box in a message compose window.)</p>
>+          to enable this checkbox.</p>
>       </li>
>-      <li><strong>Attach the source of this link to the message</strong>: If
>-        checked, the source of the specified link is added as an attachment to
>-        the message you are sending. If unchecked, just a link to the location
>-        is inserted instead. (This checkbox is only available if you open the
>-        Link Properties dialog box in a message compose window.)</li>
Again shows the patch is bit-rotted.

Comment 3

[Giacomo Magnini]

Attachment: Unbitrotted

Comment 4

[Robert Kaiser]

Comment on attachment 242452 [details] [diff] [review]
Unbitrotted

a=me for 1.1b

Comment 5

[Robert Kaiser]

Checked in on trunk and branch