Closed
Bug 356819
Opened 19 years ago
Closed 18 years ago
drag&drop to a background tab that's scrolled off the tabstrip not functional if the drag source is another application
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha7
People
(Reporter: dao, Assigned: martijn.martijn)
References
Details
Attachments
(2 files, 2 obsolete files)
|
12.74 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
|
2.62 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061015 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061015 Minefield/3.0a1
from bug 248612 comment 25:
> When the drag source is from another application, then aDragSession.sourceNode
> is probably null. It shouldn't be too hard to fix, but it might be tricky, I'll
> try to fix that in a different patch.
Reproducible: Always
|
Reporter | |
Updated•19 years ago
|
|
||
Comment 1•19 years ago
|
||
Dragging a link from my text editor to the locationbar hangs Firefox completely, but also the text editor is rather upset with a sudden CPU usage of 50%. Before it dies it complains about a script.
|
|
Reporter | |
Comment 2•19 years ago
|
||
Sounds like another bug, Ria.
|
Assignee | |
Comment 3•19 years ago
|
||
Ria, isn't that bug 317770?
|
|
Assignee | |
Comment 4•19 years ago
|
||
This fixes it for me.
This was added with bug 333791, where there was talk about dragsession.sourceNode == null when that should not happening, so I might be breaking here something on the mac, possibly.
Attachment #242982 -
Flags: review?(sspitzer)
|
|
Assignee | |
Comment 5•19 years ago
|
||
|
|
Assignee | |
Comment 6•19 years ago
|
||
Ugh, I need a better editor.
Attachment #242984 -
Flags: review?(sspitzer)
|
|
Assignee | |
Comment 7•19 years ago
|
||
Attachment #242982 -
Attachment is obsolete: true
Attachment #242983 -
Attachment is obsolete: true
Attachment #242982 -
Flags: review?(sspitzer)
|
|
||
Comment 8•19 years ago
|
||
(In reply to comment #3)
> Ria, isn't that bug 317770?
>
Yes, it is.
|
|
Assignee | |
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 9•18 years ago
|
||
Comment on attachment 242984 [details] [diff] [review]
patch
martijn, sorry for letting this sit so long in my queue.
can you get mano or gavin to review this?
Attachment #242984 -
Flags: review?(sspitzer)
|
||
Comment 10•18 years ago
|
||
Re-summarizing, I thought the problem was any non-selected tab before looking at the patch.
Assignee: nobody → martijn.martijn
Summary: drag&drop to a background tab not functional if the drag source is another application → drag&drop to a background tab that's scrolled off the tabstrip not functional if the drag source is another application
|
|
||
Comment 11•18 years ago
|
||
Comment on attachment 242984 [details] [diff] [review]
patch
This still seems to apply, r=me.
Attachment #242984 -
Flags: review+
|
|
||
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
|
||
Updated•18 years ago
|
Target Milestone: --- → Firefox 3 beta1
|
|
||
Updated•18 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin needed]
|
||
Comment 12•18 years ago
|
||
Checking in toolkit/content/widgets/tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v <-- tabbrowser.xml
new revision: 1.232; previous revision: 1.231
done
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•