356862 - checkin for bug353185 broke enable-xprint

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Minefield/3.0a1
Build Identifier: 

probably the correct fix would be to do the same with xlib/nsFontmetrics.(h,cpp) as was done for the corresponding ps files

Reproducible: Always

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

can we build with xlib?
what's the build option?

Comment 2

[Walter Meinl]

Attachment: do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

Comment 3

[Walter Meinl]

Masayuki, you think this is ok?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

I think that the logic is good. But the calculating of mLeading in nsFontMetricsXlib::RealizeFont is not good. But it's not of the scope of this bug.

r=masayki, but we need formal reviewer's review.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

Vlad:
Would you review this? I think that this is good without the calculating logic in current code.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

Sure, this stuff is going to die very very soon though.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in. thank you for your patch!

Comment 8

[Walter Meinl]

(In reply to comment #7)
> checked-in. thank you for your patch!
> 

thanks for the high-speed :)