checkin for bug353185 broke enable-xprint

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Walter Meinl, Assigned: Walter Meinl)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Minefield/3.0a1
Build Identifier: 

probably the correct fix would be to do the same with xlib/nsFontmetrics.(h,cpp) as was done for the corresponding ps files

Reproducible: Always
can we build with xlib?
what's the build option?
(Assignee)

Comment 2

12 years ago
Created attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp
(Assignee)

Comment 3

12 years ago
Masayuki, you think this is ok?
Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

I think that the logic is good. But the calculating of mLeading in nsFontMetricsXlib::RealizeFont is not good. But it's not of the scope of this bug.

r=masayki, but we need formal reviewer's review.
Attachment #242426 - Flags: review+
Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

Vlad:
Would you review this? I think that this is good without the calculating logic in current code.
Attachment #242426 - Flags: review?(vladimir)
Assignee: nobody → wuno
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 242426 [details] [diff] [review]
do the same for nsFontMetricsXlib.h,cpp as Masayuki did for nsFontMetricsPS.h,cpp

Sure, this stuff is going to die very very soon though.
Attachment #242426 - Flags: review?(vladimir) → review+
checked-in. thank you for your patch!
Blocks: 353185
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

12 years ago
(In reply to comment #7)
> checked-in. thank you for your patch!
> 

thanks for the high-speed :)
You need to log in before you can comment on or make changes to this bug.