357017 - hang after sending mail

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

version 3 alpha 1 (20061017)  (previously 20061016 for one day, 061004 and prior trunk builds before that - never a hang like this)

had just done...
* "edit message as new" on an inbox message, 
* made changes in body and addressing, 
* hit send, send completed
* hit ctrl-T
* copy it appeared in inbox (inbox is my sent folder)
* unsuccessful clicking another account  (stuck on hourglass, spinning on 50% cpu)

plain text, no attachments, no cc: to myself - nothing unusual about message.

unable to reproduce

Comment 1

[David :Bienvenu]

Attachment: [checked in] proposed fix

I saw this last night - I believe the cause is the patch I checked into bug 206408. If we get a request that's only partially processed, we need to break out of the loop. It's rare to get into that situation, since almost all move/copies only have one copy source, but there seem to be some situations where there are more than one.

Comment 2

[Mike Cowperthwaite]

This is IMAP-only?

Comment 3

[David :Bienvenu]

The code isn't imap-specific, afaik.

Comment 4

[David :Bienvenu]

fix checked in.

Comment 5

[Wayne Mery (:wsmwk)]

solid enough to check in on branch?

Comment 6

[David :Bienvenu]

It's not needed on the branch, unless I land the patch in bug 206408 on the branch as well (but I've been meaning to do that)

Comment 7

[Wayne Mery (:wsmwk)]

Resurrecting the 206408 monster and ref our email Message-ID: <[e-mail]> if you still have it...

I assume you don't want to close 206408 until you land your last patch from comment 154 on branch.  Is now a good time so it hits 2.0.0.7pre?

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 243686 [details] [diff] [review]
[checked in] proposed fix

landed on branch MOZILLA_1_8_BRANCH as part of attachment 241944 [details] [diff] [review] / bug 206408 -- 2007-01-04 bienvenu%nventure.com
mozilla/mailnews/base/src /nsMsgCopyService.cpp 1.51.2.1.