357044 - [FIX][reflow branch] ASSERTION: Different heights?: 'mButtonFrame->GetSize().height == mDisplayFrame->GetSize().height', file nsComboboxControlFrame.cpp, line 698

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Mats Palmgren (inactive)]

###!!! ASSERTION: Different heights?: 'mButtonFrame->GetSize().height == mDisplayFrame->GetSize().height', file nsComboboxControlFrame.cpp, line 698

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/forms/nsComboboxControlFrame.cpp&rev=1.375.2.1&root=/cvsroot&mark=696-698#676

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Mats Palmgren (inactive)]

Attachment: some debug data...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  So this will happen any time the combobox's mComputedHeight is smaller than the borderPadding of either the button or the display area.

I suppose I could just remove the assert or something.  Or change it to a warning.  There's no reasonable way to render that markup "right" in any case.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.