357214 - When trying to give the same shortcut (keyword) to two (or more) bookmarks, show warning

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect)

Description

[froodian (Ian Leue)]

We currently allow users to give two or more bookmarks the same keyword, but doing so causes one of the bookmarks to "win" (the first one when traversing the bookmarks tree). Per IRC, the expected behavior is probably to keep the user from giving the same keyword to more than one bookmark.  This poses some UI trickiness, since keywords can be changed both from the info panel and inline in the BM manager.

It seems to me that the best solution is to just thrown a alert - something like

"The keyword $proposedkeyword is already taken by bookmark $otherbookmarktitle.
Bookmark keywords are unique - if you want to use this keyword, please first remove it from $otherbookmarktitle"

My only worry is that throwing an alert from an inline edit seems strange.

This bug is similar to bug 303628, and any UI solution will probably be similar for both bugs.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Also if you copy and paste a bookmark that has a keyword.... :P

Comment 2

[Håkan Waara]

This will be a piece of cake if we implement the bookmark dictionary in my "cleanup keyword code" bug (don't know the number off hand).

Comment 3

[froodian (Ian Leue)]

For posterity: bug 352250

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

What happens if you copy a bookmark that has a keyword and then paste a copy?  Further, what happens if you change the url of the second copy to be non-identical?

Obviously we want to do some sort of prompt in the second case; the first is debatable, but I think to prevent things we should--though prompting on paste (and cancelling the paste?) seems evil-ish.

Comment 5

[Chris Lawson (gone)]

(In reply to comment #4)
> What happens if you copy a bookmark that has a keyword and then paste a copy?

Would silently refusing to fill in the keyword^H^H^H^H^H^H^Hshortcut field be less evil? That seems like a reasonable idea to me.

cl

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yeah, Ian mentioned that to me, too, and it seems better.

Comment 7

[Seairth Jacobs]

This appears to be a duplicate of bug 237180.

Comment 8

[Stuart Morgan]

(In reply to comment #7)
> This appears to be a duplicate of bug 237180.

It's not. We share absolutely no bookmark code, back-end or front-end, with Firefox.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to  comment #4)
> Obviously we want to do some sort of prompt in the second case; the first is
> debatable, but I think to prevent things we should--though prompting on
> paste (and cancelling the paste?) seems evil-ish.

5 years later, prompting-on-paste doesn't seem any more evil than prompting-on-edit, as long as we don't cancel the paste.  The UI of the paste would be a little tricky to get right, because we'd want the paste to succeed, so we'd have to clear the shortcut to commit the paste as a new bookmark, but then we could perhaps store the duplicate keyword and throw the user back into edit mode with the duplicate keyword prefilled and selected, for them to change.  Dunno, I guess I'd have to play with an impl to see what it felt like.