357527 - [reflow branch] Abs. pos. <select> is too narrow if <option> have ::first-letter

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Mats Palmgren (inactive)]

[reflow branch] Abs. pos. <select> is too narrow if <option> have ::first-letter

Loading the testcase gives the following warning:
WARNING: Letter(0) frame didn't implement GetPrefWidth: file nsFrame.cpp, line 2846

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Mats Palmgren (inactive)]

Attachment: Testcase #2

This testcase also warns about GetMinWidth:
WARNING: Letter(-1) frame didn't implement GetMinWidth: file nsFrame.cpp, line 2832

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yep, it needs to implement them.  And probably the inline forms as well.

(Probably needs both, for floating vs. non-floating.)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(But note that the inline forms need some major changes -- probably after merging with roc's inline reflow patch, which will make those changes easier -- and I'd rather make those first before adding new implementations.)

Comment 5

[Jonathan Kew [:jfkthame]]

The warning mentioned in comment 0 should no longer be an issue, since nsFirstLetterFrame intrinsic widths were implemented long ago; and remaining intrinsic-width issues with first-letter were just resolved in bug 385615. So I think this is WFM at this point.