357539 - Feed parser does not recognize lastBuildDate field

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Adam Kowalczyk]

When generating |updated| property of nsIFeedContainer, the parser doesn't recognize <lastBuildDate/>. This field is a common way of specifying when a feed was updated.

Comment 1

[Robert Sayre]

silly omission on my part. RSS2 has so many elements!

patch and test file coming soon

Comment 2

[Robert Sayre]

Attachment: add it to our list of the places dates come from

Comment 3

[Asaf Romano (gone)]

Comment on attachment 245113 [details] [diff] [review]
add it to our list of the places dates come from

r=mano

Comment 4

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.20; previous revision: 1.19
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate.xml,v
done
Checking in test/xml/rss2/feed_updated_lastBuildDate.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate.xml,v  <--  feed_updated_lastBuildDate.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate_priority.xml,v
done
Checking in test/xml/rss2/feed_updated_lastBuildDate_priority.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate_priority.xml,v  <--  feed_updated_lastBuildDate_priority.xml
initial revision: 1.1
done

Comment 5

[Robert Sayre]

Comment on attachment 245113 [details] [diff] [review]
add it to our list of the places dates come from

drivers: this a pain for API users. automated test coverage is good.

Comment 6

[Jay Patel [:jay]]

Comment on attachment 245113 [details] [diff] [review]
add it to our list of the places dates come from

Approved for 1.8 branch, a=jay for drivers.

Comment 7

[Robert Sayre]

Checking in FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.16; previous revision: 1.1.2.15
done
Checking in xml/rss2/feed_updated_lastBuildDate.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate.xml,v  <--  feed_updated_lastBuildDate.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in xml/rss2/feed_updated_lastBuildDate_priority.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_lastBuildDate_priority.xml,v  <--  feed_updated_lastBuildDate_priority.xml
new revision: 1.1.2.1; previous revision: 1.1
done
~/bonecho/mozilla/toolkit/components/fee

Comment 8

[Tony Chung [:tchung]]

hi sayre, can you add testcases to this bug so QA can verify?  or if its not a simple verification for us, would you be able to verify it on the 1.8 branch?  You'll have to change the keywords from "fixed1.8.1.2" to "verified1.8.1.2". Thanks!