357644 - Unneeded changes to using_priv_help.xhtml

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text

My bad: another change I was preparing for the doc in subject slipped in the patch for bug 356408, on both trunk and branch. I apologize.


Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Don't rename pref panels, stupid me!

Comment 2

[Giacomo Magnini]

Other small errors spotted. Will clean them all at once.

Comment 3

[Giacomo Magnini]

Attachment: Same as above, plus ome fixes for nav_help, too.

Comment 4

[Stefan [:stefanh]]

Comment on attachment 243202 [details] [diff] [review]
Same as above, plus ome fixes for nav_help, too.

     visited web pages from the lists.</li>
   <li>If you wish to set a limit on how long pages remain in the history list,
     click the field next to <q>Remember visited pages for the last [__] days
-    </q> and type a number of pages.</li>
+    </q> and type a number of days.</li>
 </ol>

This is an improvement, but do you think we can fix it up a bit  more? The sentence "If you wish to set a limit on how long pages remain in the history list,  click the field next to <q>Remember visited pages for the last [__] just doesn't feel correct (the field is not *next* to the sentence) :) Looking at the whole section it doesn't even seems accurate, it's #4 in a list that begins with:
"To delete all pages from the Location Bar or history list, begin from the
  Navigator window:"

My suggestion is to nuke the <li> and make it a "<strong>Tip</strong>:" instead, something like this:

"You can specify how many days (for how long) pages will remain in the history list in <q>...

(IanN seems overburdened, so you can dump the request on me instead)

Comment 5

[Giacomo Magnini]

Attachment: This looks better with stefanh proposal...

Comment 6

[Stefan [:stefanh]]

Comment on attachment 243624 [details] [diff] [review]
This looks better with stefanh proposal...

-  <li>If you wish to set a limit on how long pages remain in the history list,
-    click the field next to <q>Remember visited pages for the last [__] days
-    </q> and type a number of pages.</li>
 </ol>
 
+<p><strong>Tip</strong>: You can specify for how many days pages will remain in
+  the history list by checking the <q>Remember visited pages for the last [__]
+  days</q> option and entering the number of days in the field.</p>
+

Hmm, I sort of feel that it is a checkbox now (but it's not).

Thinking of it, we don't have to be that specific since this is just a tip and it's pretty self-explanatory. So, my proposal is (more simple, I think):

'In "Remember visited pages for the last [__] days", you can set the number of days pages will remain in the history list.'

Comment 7

[Giacomo Magnini]

Attachment: What stefanh asked.

Comment 8

[Robert Kaiser]

Comment on attachment 243771 [details] [diff] [review]
What stefanh asked.

a=me for 1.1b

Comment 9

[Mark Banner (:standard8)]

Checked in to trunk:

Checking in suite/locales/en-US/chrome/common/help/using_priv_help.xhtml;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/help/using_priv_help.xhtml,v  <--  using_priv_help.xhtml
new revision: 1.64; previous revision: 1.63
done
Checking in suite/locales/en-US/chrome/common/help/nav_help.xhtml;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/help/nav_help.xhtml,v  <--  nav_help.xhtml
new revision: 1.64; previous revision: 1.63

Giacomo - the patch doesn't apply cleanly to the 1.8 branch. I think there's just a minor change somewhere that's required. Could you post an updated patch so that I can make sure we get the right thing?

Comment 10

[Robert Kaiser]

Checked into branch with hand-applying the first hunk of nav_help.xhtml (may just be whitespace difference or something):

Checking in using_priv_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/Attic/using_priv_help.xhtml,v  <--  using_priv_help.xhtml
new revision: 1.56.6.7; previous revision: 1.56.6.6
done
Checking in nav_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/Attic/nav_help.xhtml,v  <--  nav_help.xhtml
new revision: 1.53.8.8; previous revision: 1.53.8.7
done