357706 - Alarms fired too late (alarm timer stopped while hibernating)

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Matp75]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Thunderbird 1.5.0.7(20060909) ligthning (2006100618)

alarms seems to be fired randomly (when they are) and are mostly late (sometimes of several hours).

Reproducible: Always

Steps to Reproduce:
1. create an event or receive an invitation (tried both) 
2. wait for the event time


Actual Results:  
nothing happens or after sometime, a alarm window appears

Expected Results:  
I should not be warned for events after they occured as this is pretty useless.

Comment 1

[Stefan Sitter [:ssitter]]

Do you suspend or hibernate Windows while Thunderbird is running?

Comment 2

[Matp75]

yes, I'm moving this laptop several times a day and I usually hibernate with thunderbird opened and restart it later. (Nontheless after a while, I reboot the pc to free up memory). I also usually hibernate it at night (but not always) 

Comment 3

[Stefan Sitter [:ssitter]]

The cause for this issue is probably the same as mentioned in Bug 357079 Comment #6.

Comment 4

[Matp75]

this stills occurs with ligthning 0.5pre 2007032003 + thunderbird 2.0pre fr 20070320

Comment 5

[Carl]

Don't know if this is the same issue, but the alarm continues to go off even when TB and the PC is properly shut down then restarted.  I had an alarm set for a meeting August 3 but did not have the computer on at that time.  A week later (after a vacation), the alarm came on for that meeting when I started the computer.

Comment 7

[David O'Leary]

Please increase the severity/priority of this one. Reminders are a very important piece of a Calendar and if they don't work consistently, they're worthless. I'm considering using an alternate calendar because I missed an important meeting because my reminder fired 4 hours late.

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Please only nominate flags (set to ?) instead of approving (set to +) unless you're part of the official Calendar team.

Comment 9

[Simon Paquet [:sipaq]]

We won't use the blocking flags until later in the release cycle.

Comment 10

[Peter]

I really hope somebody can fix this issue. I also have to move my laptop about and I have missed three pretty important events already. A reliable alarm function is an essential part of a calendar.

Comment 11

[J Pearson]

Have voted.
This is very important: reminders must be reliable, and a calendar program is one most users want to keep running all the time, not restart several times a day.

Comment 12

[George Snyder]

I also voted for this one.  Reliable alarms are essential.  My laptop is in standby mode while I am commuting, and in hibernation overnight on weekends.  Thunderbird (and most other programs I use) remain open.  I only shut them down when Windows XP requires rebooting (about every two weeks on average).

Comment 13

[Bas van den Bosch]

How should we fix this? Do we store the last datetime-value of the alarm-timer somewhere and do we compare it to the current time every minute or something like that? If the difference in time is more then a minute then rewrite the alarm-buffer and check for alarms which should have fired in between time?

Comment 14

[Davide]

I've got the same problem here, Thunderbird 2.0.0.14 + Lightning 0.8 build 2008033120. After hibernating the calendar alarms are not fired at all or fired too late. I thinks this should be fixed with urgency. Hibernating/sleeping it's very common for laptop users, and reliable alarms are vital for a calendar application. Thanks

Comment 15

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

This works for me, but I don't know if there are some concerns about performance.

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 322097 [details] [diff] [review]
Patch v1

Looks like a good idea to me, daniel what do you say?

r=philipp if daniel agrees.

Comment 17

[Daniel Boelzle [:dbo]]

I don't think is a problem.

Comment 18

[Martin Schröder [:mschroeder]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 19

[Peter]

Fixed? Patch? That would be great! But how do we get this patch and how do we apply it?

Comment 20

[Philipp Kewisch [:Fallen][📱📆]]

Should be in the next nightly, check tomorrow or in 2 days:

ftp://ftp.mozilla.org/pub/calendar/lightning/nightly/latest-mozilla1.8/
ftp://ftp.mozilla.org/pub/calendar/sunbird/nightly/latest-mozilla1.8/