357912 - [% wrap=false %] no longer works?

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

after the recent website changes, the following pages have navigation chrome where they didn't before:

http://www.mozilla.com/en-US/test/sample-details.html
http://www.mozilla.com/en-US/test/sample-eula.html

perhaps [% wrap=false %] no longer works?

we'll need something like that, since we don't want the navigation bar chrome for the details and eulas for fx 2 / tb 2.

Comment 1

[Reed Loden [:reed]]

No, it doesn't. The new site is all PHP-based. Fixed the issue, though.

Sending        trunk/en-US/test/sample-details.html
Sending        trunk/en-US/test/sample-eula.html
Transmitting file data ..
Committed revision 907.

Comment 2

[(not reading, please use [e-mail] instead)]

thanks reed.  is there a new trick to doing this?  (we'll need to use it for bugs #357749, 357752, 357832, 357833)

Comment 3

[Reed Loden [:reed]]

Whereas the old system required overriding the wrapper, the new system requires the wrapper includes be added to every page. By not including the includes, the page is just plain.

See these URLs for what the file looks like now:
http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/test/sample-details.html
http://svn.mozilla.org/projects/mozilla.com/trunk/en-US/test/sample-eula.html

Comment 4

[Reed Loden [:reed]]

oh, I didn't notice that you need a complete file. :p

/me fixes

Sending        en-US/test/sample-details.html
Sending        en-US/test/sample-eula.html
Transmitting file data ..
Committed revision 908.

Now it's really fixed... :)

Comment 5

[(not reading, please use [e-mail] instead)]

verified, thanks reed!

note, my image tags are busted, but that's something I'd need to fix separately

<img src="../images/firefox-logo-64x64" alt="Firefox">

Comment 6

[Reed Loden [:reed]]

(In reply to comment #5) 
> note, my image tags are busted, but that's something I'd need to fix separately
> 
> <img src="../images/firefox-logo-64x64" alt="Firefox">

Bah, I fixed this in the original fix, but I overwrote it when I added the original file back. :(

Sending        test/sample-details.html
Sending        test/sample-eula.html
Transmitting file data ..
Committed revision 921.

This will be updated in the next sync.