358121 - Phishing detector throws an error and quits early when opening a .eml message

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Open a .eml file from your desktop in Thunderbird. Our phishing detector tries to get the folder from the mailnews url being loaded. Because this is a .eml file we don't have a folder associated with it so an error exception gets thrown in the JS code.

We can either use a try/catch in phishingDetector.js or modify nsMailboxUrl::GetFolder to not throw an error....

the try/catch is probably less intrusive on other callers who may be counting on the error code.

Comment 1

[Scott MacGregor]

Attachment: use a try/catch

Comment 2

[Mike Cowperthwaite]

The patch seen here only affects phishingDetector.js, but according to CVS log a related patch was checked in for mailWindowOverlay.js.

In other words, this is a dupe of an existing bug.

Verified fixed on 2a1-1026; I don't yet have a current trunk build.

Comment 3

[Mike Cowperthwaite]

*** Bug 338536 has been marked as a duplicate of this bug. ***

Comment 4

[Scott MacGregor]

I noticed the second call site just before I checked in so I fixed it too. Mike's right I should have posted a new patch for proper record keeping. Sorry mike.

Comment 5

[Mike Cowperthwaite]

Neil posted about this patch in m.d.a.seamonkey:
> [Scott] made two minor errors; a) he forgot to reindent the second call site
> (he seems to have applied a -w patch or something) and b) by moving the
> condition into the try block you can avoid the null check.

Bug 358247 is for the Seamonkey port of this patch.