Closed
Bug 358528
Opened 19 years ago
Closed 19 years ago
Leak Monitor locks Firefox.exe during startup
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
People
(Reporter: polidobj, Assigned: igor)
References
()
Details
(Keywords: crash, regression, verified1.8.1.1)
Attachments
(1 file)
|
614 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This was first seen in the 20061027 1533pdt build. But it was not present in nightly earlier that day.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-27+06%3A56&maxdate=2006-10-27+15%3A33&cvsroot=%2Fcvsroot
|
||
Updated•19 years ago
|
Keywords: regression
|
Reporter | |
Comment 1•19 years ago
|
||
This is from bug 357169. In the debugger I'm hitting a stack overflow because JS_MapGCRoots calls itself.
JS_PUBLIC_API(uint32)
JS_MapGCRoots(JSRuntime *rt, JSGCRootMapFun map, void *data)
{
- GCRootMapArgs args;
- uint32 rv;
-
- args.map = map;
- args.data = data;
- JS_LOCK_GC(rt);
- rv = JS_DHashTableEnumerate(&rt->gcRootsHash, js_gcroot_mapper, &args);
- JS_UNLOCK_GC(rt);
- return rv;
+ return JS_MapGCRoots(rt, map, data);
}
Depends on: 357169
|
|
Reporter | |
Updated•19 years ago
|
|
||
Comment 2•19 years ago
|
||
It needs to call js_MapGCRoots instead (lowercase "js").
Assignee: nobody → general
Severity: normal → critical
Component: General → JavaScript Engine
Keywords: crash
OS: Windows XP → All
Product: Firefox → Core
QA Contact: general → general
Hardware: PC → All
|
Assignee | |
Comment 3•19 years ago
|
||
|
||
Updated•19 years ago
|
Attachment #243912 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
I committed the patch from comment 3 to the trunk:
Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v <-- jsapi.c
new revision: 3.286; previous revision: 3.285
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 5•19 years ago
|
||
I looks like Leak Monitor stopped registering leaks altogether now.
Add bookmark / customise toolbars
don't result in the leak warning popup anymore
|
|
||
Comment 6•19 years ago
|
||
(In reply to comment #5)
> I looks like Leak Monitor stopped registering leaks altogether now.
>
> Add bookmark / customise toolbars
> don't result in the leak warning popup anymore
>
see Bug 358661
|
||
Updated•19 years ago
|
Flags: in-testsuite-
|
|
Assignee | |
Updated•19 years ago
|
|
||
Updated•19 years ago
|
|
|
Assignee | |
Comment 7•19 years ago
|
||
*** Bug 358661 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 8•19 years ago
|
||
The committed patch for 1.8.1 for the bug 357169 already contains the fix.
No longer blocks: 358661
Keywords: fixed1.8.1.1
|
|
||
Comment 9•19 years ago
|
||
Verified fixed for 1.8.1.1 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.1pre) Gecko/20061202 BonEcho/2.0.0.1pre also on Linux FC6
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.1 → verified1.8.1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•