Closed Bug 358528 Opened 13 years ago Closed 13 years ago

Leak Monitor locks Firefox.exe during startup

Categories

(Core :: JavaScript Engine, defect, critical)

defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: polidobj, Assigned: igor)

References

()

Details

(Keywords: crash, regression, verified1.8.1.1)

Attachments

(1 file)

Keywords: regression
This is from bug 357169.  In the debugger I'm hitting a stack overflow because JS_MapGCRoots calls itself.  

 JS_PUBLIC_API(uint32)
 JS_MapGCRoots(JSRuntime *rt, JSGCRootMapFun map, void *data)
 {
-    GCRootMapArgs args;
-    uint32 rv;
-
-    args.map = map;
-    args.data = data;
-    JS_LOCK_GC(rt);
-    rv = JS_DHashTableEnumerate(&rt->gcRootsHash, js_gcroot_mapper, &args);
-    JS_UNLOCK_GC(rt);
-    return rv;
+    return JS_MapGCRoots(rt, map, data);
 }
Depends on: 357169
It needs to call js_MapGCRoots instead (lowercase "js").
Assignee: nobody → general
Severity: normal → critical
Component: General → JavaScript Engine
Keywords: crash
OS: Windows XP → All
Product: Firefox → Core
QA Contact: general → general
Hardware: PC → All
Attached patch FixSplinter Review
Assignee: general → igor.bukanov
Status: NEW → ASSIGNED
Attachment #243912 - Flags: review?(brendan)
Blocks: 357169
No longer depends on: 357169
Attachment #243912 - Flags: review?(brendan) → review+
I committed the patch from comment 3 to the trunk:

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.286; previous revision: 3.285
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I looks like Leak Monitor stopped registering leaks altogether now.

Add bookmark / customise toolbars 
don't result in the leak warning popup anymore
(In reply to comment #5)
> I looks like Leak Monitor stopped registering leaks altogether now.
> 
> Add bookmark / customise toolbars 
> don't result in the leak warning popup anymore
> 

see Bug 358661
Flags: in-testsuite-
No longer blocks: 357169
Depends on: 357169
Blocks: 357169
No longer depends on: 357169
*** Bug 358661 has been marked as a duplicate of this bug. ***
The committed patch for 1.8.1 for the bug 357169 already contains the fix.
No longer blocks: 358661
Keywords: fixed1.8.1.1
Verified fixed for 1.8.1.1 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.1pre) Gecko/20061202 BonEcho/2.0.0.1pre also on Linux FC6
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.