358661 - Leak monitor doesn't work anymore

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Peter van der Woude [:Peter6]]

after Bug 358528 landed Leak Monitor has stopped regestering leaks

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I go to about:config and then enter this in the URL bar:
javascript:void(alert(Components.classes["@mozilla.org/observer-service;1"].getService(Components.interfaces.nsIObserverService).addObserver({},"foo-topic",false)))
which should cause a leak, in my debug build of leak-monitor I see:

WARNING: NS_ENSURE_TRUE(str) failed: file /home/dbaron/builds/trunk/mozilla/extensions/leak-monitor/src/leakmonJSObjectInfo.cpp, line 113
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /home/dbaron/builds/trunk/mozilla/extensions/leak-monitor/src/leakmonReport.cpp, line 136
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /home/dbaron/builds/trunk/mozilla/extensions/leak-monitor/src/leakmonService.cpp, line 380

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm seeing the same failure in my 1.8 branch build, though.

Comment 3

[Wayne Mery (:wsmwk)]

should patch to bug 357169 be backed out?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be helpful if somebody isolated when the regression actually occurred.  I haven't had the chance to do that, and I'm not sure that "after bug 358528 landed" is correct.

Comment 5

[Peter van der Woude [:Peter6]]

Bonsai: 2006-10-27 12:38 , checkin for Bug 357169 (GC temp roots cleanup) which caused bug Bug 358528 (crash on startup with Leak Monitor installed)

regressionwindow:
from checkin for Bug 357169 to checkin for Bug 358528

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-27+12%3A38&maxdate=2006-10-28+15%3A57&cvsroot=%2Fcvsroot

but it's probably a leftover from Bug 357169

Comment 6

[Igor Bukanov]

This is just a replica of 358528.

*** This bug has been marked as a duplicate of 358528 ***

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I don't see how this can be a duplicate of bug 358528 - that bug is about a hang due to infinite recursion, this one is about leak monitor not being effective. There's no hang involved here. It was also reported after bug 358528 was fixed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Hmm, I'm not sure I can reproduce this bug - if I install Leak Monitor into a clean profile, and run either a branch build or trunk build from yesterday (both 2006-11-28-04), and then follow the steps in bug 323402, I see a leak monitor leak notification window. The tree part of the window is empty, but I've been told that that happens sometimes and isn't an indication of breakage.

Comment 9

[Daniel Veditz [:dveditz]]

A broken tool is sucky (although it's not clear it really is broken from the comments), but it's not going to block.

Is it really broken on the branch?

Comment 10

[Brendan Eich [:brendan]]

(In reply to comment #8)
> Hmm, I'm not sure I can reproduce this bug - if I install Leak Monitor into a
> clean profile, and run either a branch build or trunk build from yesterday
> (both 2006-11-28-04), and then follow the steps in bug 323402, I see a leak
> monitor leak notification window. The tree part of the window is empty, but
> I've been told that that happens sometimes and isn't an indication of breakage.

Is this bug still valid?

/be

Comment 11

[:Gavin Sharp [email: [e-mail]]]

I'm waiting for Peter to confirm - I'm guessing he had different steps to reproduce than I did.

Comment 12

[Peter van der Woude [:Peter6]]

The bookmark leaks have misteriously vanished but I see the monitor pop-up now and than.

Resolving for now.

Comment 13

[Peter van der Woude [:Peter6]]

After some more testing is seems it isn't properly working after all.

with the extension, close a bookmark or open the menu-customise window doesn't leak.

leak-gauge does show leaks.

Eiter leak-gauge is making mistakes or the extension doesn't work like it used to before bug 357169 landed

The only leaks I see with the extension, pop up out of the blue and are unreproducable.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

<Owner> I'm trying to track down why dbaron's leak monitor extension doesn't work in firefox 2.0.0.1rc -- I've narrowed it down to working in the nightly on 2006-11-09-03-mozilla1.8 and not in 2006-11-10-05-mozilla1.8  (on windows)

Comment 15

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #14)
> 2006-11-09-03-mozilla1.8 and not in 2006-11-10-05-mozilla1.8  (on windows)

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&date=explicit&mindate=2006-11-09+01%3A00&maxdate=2006-11-10+06%3A00

Bug 353090?

Comment 16

[Manish Singh]

If I revert the patch in bug #353090, the about:config/javascript: test works, on current 1.8 branch code.

Comment 17

[Daniel Veditz [:dveditz]]

We probably do want this tool to work on the branch, and it sounds like there's some recent progress, but I'm not sure it's an actual blocker since this is not part of the end-user product.

-> dbaron because bug 353090 is currently being blamed as the regressor

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I'm fixing this in leak monitor.

I discussed this with brendan briefly, and JS_ValueToString isn't expected to work after a JS_ClearScope on Object.prototype.  So I've written my own simple ValueToString in leak monitor that does what I need.

I'll try to release a new version of leak monitor with this fix in the next few days.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed by release of leak monitor 0.3.5:
https://addons.mozilla.org/firefox/2490/
http://dbaron.org/mozilla/leak-monitor/

Comment 20

[Jay Patel [:jay]]

Clearing nomination, looks like dbaron fixed this in the leak monitor.