Switch to use native NSSearchField widget in Bookmark Manager

RESOLVED FIXED

Status

Camino Graveyard
Bookmarks
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

Trunk
PowerPC
Mac OS X
fixed1.8.1.1
Dependency tree / graph

Details

Attachments

(2 attachments, 1 obsolete attachment)

20.57 KB, application/octet-stream
Details
9.03 KB, patch
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Splitting off from bug 330666, since they don't need to be tied together.
(Assignee)

Comment 1

11 years ago
Created attachment 243984 [details] [diff] [review]
fix

Switches to NSSearchField (also changes some unrelated #defines to an enum and removes one unused #define).
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #243984 - Flags: review?
(Assignee)

Comment 2

11 years ago
Created attachment 243985 [details]
corresponding nib

Comment 3

11 years ago
Comment on attachment 243984 [details] [diff] [review]
fix

Looks good code-wise. Will the gray "all" text still be written as a placeholder string?

Do we want to persist the last chosen search filter for history and bookmarks?
Attachment #243984 - Flags: review? → review+
(Assignee)

Comment 4

11 years ago
Created attachment 244193 [details] [diff] [review]
with hint text (checked in on trunk)

Nope, I realized that I forgot it when I started looking at the main search field but didn't remember to obsolete the patch before you got to it.  This version adds the one line that will do that.

Smokey, could you put this through its paces as a 10.3 sanity check?
Attachment #243984 - Attachment is obsolete: true
Attachment #244193 - Flags: review?(alqahira)
Comment on attachment 244193 [details] [diff] [review]
with hint text (checked in on trunk)

This builds and appears to work properly on 10.3.9 with a 10.3.0 SDK build, so r=ardissone
Attachment #244193 - Flags: review?(alqahira) → review+
(Assignee)

Comment 6

11 years ago
Comment on attachment 244193 [details] [diff] [review]
with hint text (checked in on trunk)

Simon, would you be interested in sr'ing this?
Attachment #244193 - Flags: superreview?(sfraser_bugs)
Depends on: 359218
(Assignee)

Updated

11 years ago
Attachment #244193 - Flags: superreview?(sfraser_bugs) → superreview?(mikepinkerton)
Comment on attachment 244193 [details] [diff] [review]
with hint text (checked in on trunk)

sr=pink
Attachment #244193 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 8

11 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
(Assignee)

Comment 9

11 years ago
Backed out on branch since it hosed the build; the 10.3 SDK needs to land first. Go me :P
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1.1
Resolution: FIXED → ---

Updated

11 years ago
Attachment #244193 - Attachment description: with hint text → with hint text (checked in on trunk)
Blocks: 360345
(Assignee)

Comment 10

11 years ago
Checked in on MOZILLA_1_8_BRANCH
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Keywords: fixed1.8.1.1
You need to log in before you can comment on or make changes to this bug.