358688 - Day/Week(Multiday)view: Move widths and heights to CSS

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061029 Calendar/0.4a1

Some widths and heights are hardcoded into calendar-multiday-view, such as in the reorient method.  

These sizes should be moved into CSS using selectors.  

Without a change, theme CSS cannot adjust grid box sizes to match theme font sizes.

Reproducible: Always

Comment 1

[gekacheka]

Attachment: Move reorient widths and heights to CSS with attribute selectors

(patch -l -p 2 -i file.patch)

(Also remove ineffective style on button)

When successful, appearance should be the same after patch.

(Forthcoming bugs with CSS changes will depend on this patch.)

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244052 [details] [diff] [review]
Move reorient widths and heights to CSS with attribute selectors

r=mvl
For next patches, please ask review from a specific person, otherwise patches are very likely to be forgotten.

Comment 3

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED