Day/Week(Multiday)view: Move widths and heights to CSS

RESOLVED FIXED in Sunbird 0.5

Status

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: gekacheka, Unassigned)

Tracking

unspecified
Sunbird 0.5
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061029 Calendar/0.4a1

Some widths and heights are hardcoded into calendar-multiday-view, such as in the reorient method.  

These sizes should be moved into CSS using selectors.  

Without a change, theme CSS cannot adjust grid box sizes to match theme font sizes.

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 244052 [details] [diff] [review]
Move reorient widths and heights to CSS with attribute selectors

(patch -l -p 2 -i file.patch)

(Also remove ineffective style on button)

When successful, appearance should be the same after patch.

(Forthcoming bugs with CSS changes will depend on this patch.)
Attachment #244052 - Flags: first-review?
(Reporter)

Updated

12 years ago
Blocks: 358692
(Reporter)

Updated

12 years ago
Blocks: 358695
(Reporter)

Updated

12 years ago
Blocks: 358701
Comment on attachment 244052 [details] [diff] [review]
Move reorient widths and heights to CSS with attribute selectors

r=mvl
For next patches, please ask review from a specific person, otherwise patches are very likely to be forgotten.
Attachment #244052 - Flags: first-review? → first-review+
Whiteboard: [needs checkin]
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: --- → Sunbird 0.5
You need to log in before you can comment on or make changes to this bug.