359543 - [cocoa] Theme switching is broken

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[Stefan [:stefanh]]

SeaMonkey trunk 2006110207, mac os x

Theme switching seems to be broken, at least on mac. Even though I get the dialog after I choose a theme, SeaMonkey doesn't switch to the selected theme.

Steps to reproduce:

1) Get a trunk build and start it with a fresh profile.
2) View --> Apply Theme --> Modern, note that the dialog appear.
3) Quit Seamonkey
4) Start SeaMonkey (use the previous profile, of course) and notice that the skin is Classic

Further notice: No checkmarks appear on the theme menuitems...

Comment 1

[[e-mail]]

1. Is the preference general.skins.selectedSkin set?
2. Is it set after you apply theme, but before you restart?
3. Is it set after you restart?
4. If you paste this into the JS console, does it change the theme?
/* Note: you need to evaluate this all as one long string */
var nsIChromeRegistrySea = Components.interfaces.nsIChromeRegistrySea;
var chromeClass = Components.classes['@mozilla.org/chrome/chrome-registry;1'];
var chromeRegistry = chromeClass.getService(nsIChromeRegistrySea);
chromeRegistry.selectSkin("modern/1.0", true); chromeRegistry.refreshSkins();

Comment 2

[Stefan [:stefanh]]

Works in 2006092806
Broken in 2006092906

Hmm...

Comment 3

[Stefan [:stefanh]]

(In reply to comment #1)
> 1. Is the preference general.skins.selectedSkin set?
> 2. Is it set after you apply theme, but before you restart?
> 3. Is it set after you restart?
> 4. If you paste this into the JS console, does it change the theme?
> /* Note: you need to evaluate this all as one long string */
> var nsIChromeRegistrySea = Components.interfaces.nsIChromeRegistrySea;
> var chromeClass = Components.classes['@mozilla.org/chrome/chrome-registry;1'];
> var chromeRegistry = chromeClass.getService(nsIChromeRegistrySea);
> chromeRegistry.selectSkin("modern/1.0", true); chromeRegistry.refreshSkins();
> 

oh, missed your comment. Hang on...

Comment 4

[Stefan [:stefanh]]

(In reply to comment #1)
> 1. Is the preference general.skins.selectedSkin set?
> 2. Is it set after you apply theme, but before you restart?
> 3. Is it set after you restart?
> 4. If you paste this into the JS console, does it change the theme?
> /* Note: you need to evaluate this all as one long string */
> var nsIChromeRegistrySea = Components.interfaces.nsIChromeRegistrySea;
> var chromeClass = Components.classes['@mozilla.org/chrome/chrome-registry;1'];
> var chromeRegistry = chromeClass.getService(nsIChromeRegistrySea);
> chromeRegistry.selectSkin("modern/1.0", true); chromeRegistry.refreshSkins();
> 
1) No
2) Yes
3) No
4) Yes (sigh, not able to paste from clipboard)

Comment 5

[[e-mail]]

(In reply to comment #2)
>Works in 2006092806
>Broken in 2006092906
That was the cocoa widget change, wasn't it?

Comment 6

[Stefan [:stefanh]]

(In reply to comment #5)
> (In reply to comment #2)
> >Works in 2006092806
> >Broken in 2006092906
> That was the cocoa widget change, wasn't it?
> 

Yes. Fwiw, the answer to your questions (1-3, didn't checked 4 - but I assume it works) would be the same on 2006092806. Hmm.

Comment 7

[Stefan [:stefanh]]

I made a (xpfe) trunk build with _PLATFORM_DEFAULT_TOOLKIT='mac' instead of 'cocoa'. It appears that theme switching works with the old toolkit.

Btw, I checked with a phlox suiterunner build. We lack the menuitems - but we seem to have dynamic theme switching there - general.skins.selectedSkin is set and changing it makes the themes switch on the fly (but I suppose that's known).

Comment 8

[[e-mail]]

Well, the obvious thing different between the two toolkits is the menu handling... do both toolkits set the pref to the same value? I'm wondering whether the cocoa toolkit isn't updating the DOM or firing the event correctly.

Comment 9

[Stefan [:stefanh]]

I just tried this on a recent nightly - and it seems to work now.