359694 - Search context menu item requires cmd/shift keys to be pressed before the menu is opened

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[froodian (Ian Leue)]

This is a followup from bug 331670.  STR:

1. Select some text
2. Invoke context menu (with no modifiers)
3. Press shift/cmd modifier
4. Choose "Search" CM item

What happens: Doesn't respect modifiers unless you press them before opening the menu.

What we want to do is just give the search context menu item kItemsNeedingOpenBehaviorAlternatesTag (in the nib), so the code will make cmd/shift alternates for it.  However, since it already has a tag, this'll be a tricky fix, since it'll need to have two tags somehow, or some sort of bitmask.  Either that, or some other solution not using kItemsNeedingOpenBehaviorAlternatesTag, but that'll probably mean writing the same code twice.

Then, in |searchForSelection| if [aSender isAlternate] check [aSender
keyEquivalentModifierMask] instead of event key modifiers.

Targetting 1.1 for now, since it's a landing followup, but consider it an early candidate for bumping.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.