360331 - getBrowserSelection() (context menu search) does not get text from input or textarea

Status: RESOLVED DUPLICATE of bug 565717

(Firefox :: Search, defect)

Description

[Ben Basson]

The browser.js function getBrowserSelection() does not return text from either input or textarea nodes, and this is limiting the scope of "Search <Engine> for <String>" on the context menu.

An easy fix would be something like this (untested, but I've implemented the same behaviour for the next release of Context Search):

var fElm = document.commandDispatcher.focusedElement;
if ((fElm instanceof HtmlInputElement && String.toLowerCase(fElm.type) == "text) || fElm instanceof HTMLTextAreaElement) {
  return (fElm.selectionStart < fElm.selectionEnd) ? fElm.value.substring(fElm.selectionStart, fElm.selectionEnd) : null;
}

Comment 1

[:Gavin Sharp [email: [e-mail]]]

No need for the toLowerCase, the .type getter will always return a lowercased string.

Comment 2

[Ben Basson]

Ah, I didn't know - thanks.

Comment 3

[Wayne Mery (:wsmwk)]

reported also in bug 125487 (at that time for suite of course)

Comment 4

[Ben Basson]

Attachment: Additionally extract selection from HTMLInputElement and HTMLTextAreaElement

First stab at suggestion above.

Comment 5

[Wayne Mery (:wsmwk)]

Ben, you need to request review and/or cc someone on the bug if you want patch to be examined