360814 - remote content for (custom) thunderbird start page do not show anymore

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Set Thunderbird Start Page Location to http://www.mozilla.org/. Click Go > Mail Start Page. Remote content - at least images but it seems CSS as well - are not showing up anymore.

This broke on branch 2006-11-04 -> 2006-11-05.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-04+04%3A00%3A00&maxdate=2006-11-05+04%3A00%3A00&cvsroot=%2Fcvsroot

Though this bug should be fixed, on a side note I may add that having a UI option for setting the start page (with a chrome:// url as default!) is *very* odd. This if anything should be and about:config option, I really doubt many people are using it.

Comment 1

[Magnus Melin [:mkmelin]]

Sorry, the bonsai link should be for branch http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-04+04%3A00%3A00&maxdate=2006-11-05+04%3A00%3A00&cvsroot=%2Fcvsroot
(can't check it, bonsai doesn't work atm)

Comment 2

[Magnus Melin [:mkmelin]]

Likely caused by fixes for bug 330443 and/or bug 359479.

Works fine on trunk. 

Comment 3

[Magnus Melin [:mkmelin]]

This broke on trunk too sometime 2006-11-20 -> 2006-11-23. 
Fallout from bug 357321 perhaps.

Comment 4

[Scott MacGregor]

Attachment: a fix

This allows remote images if the url loaded into the message pane is an http or https url (aRequestingLocation is the message pane url not the requesting location url trying to load the remote image). I think this should be safe while still blocking remote content in nested iframes from a mail message.

Comment 5

[Scott MacGregor]

Comment on attachment 252101 [details] [diff] [review]
a fix

so far this has been passing my test cases.

Comment 6

[[e-mail]]

What about file: URLs? I am guessing here because it's already special cased in http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgContentPolicy.cpp#303

Comment 7

[Scott MacGregor]

Neil, are you wondering if we should allow a user to set a file url as their start page which in turn has remote images in it? I wonder how common that would be in practice...

Comment 8

[Magnus Melin [:mkmelin]]

Using a file url and local images doesn't work either, bug 364613. 
The remote content works fine now.