Closed Bug 360821 Opened 13 years ago Closed 13 years ago

Event creation fails if calendar view was not shown before

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Lightning 0.5

People

(Reporter: ssitter, Assigned: jminta)

Details

(Keywords: regression)

Attachments

(1 file)

Event creation fails if calendar view was not shown before

Steps to Reproduce:
1. Start Thunderbird. Do _not_ switch to calendar view!
2. Select File->New->Event or press the toolbar button

Actual Results:
Nothing happens. Console shows the following error:
  Error: this.mStartDate has no properties
  Source: chrome://calendar/content/calendar-multiday-view.xml line: 2151

Expected Results:
New event dialog is shown.

Regression date:
 Works in Lightning/0.4a1 (2006110607)
 Fails in Lightning/0.4a1 (2006110708)

Additional Information:
If one of the calendar views is displayed before the event creation works. But in difference to the previous build the event time is now always initialized with 00:00 instead of the current time as before.
Using Lightning/0.4a1 (2006111506) the error location has changed:
  Error: this.mStartDate has no properties
  Source: chrome://calendar/content/calendar-multiday-view.xml Line: 2175
Flags: blocking-calendar0.5?
I still don't have a good environment for testing lightning, but this should solve the problem.  Would love if someone could confirm.
Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

I bet Clint can test/review this.
Attachment #247618 - Flags: first-review?(ctalbert.moz)
Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

Looks good. Tested on WinXP 20061121 Thunderbird, with Lightning as of 20061201 (dev build).
Attachment #247618 - Flags: first-review?(ctalbert.moz) → first-review+
Attachment #247618 - Flags: second-review?(dmose)
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #247618 - Flags: second-review?(dmose)
This bug is very ugly.  We have a patch in hand.  I think this has a shot at landing soon, so it can block 0.5 for now.
Flags: blocking-calendar0.5? → blocking-calendar0.5+
Whiteboard: [needs second-review]
Target Milestone: --- → Lightning 0.5
Whiteboard: [needs second-review] → [needs second-review][patch in hand]
Attachment #247618 - Flags: second-review?(mvl)
Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

r=lilmatt
Attachment #247618 - Flags: second-review?(mvl) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Windows 2000 → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [needs second-review][patch in hand]
VERIFIED with Tb 2.0.0.4pre & Lightning 0.5pre (2007052205) on WindowsXP.
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
You need to log in before you can comment on or make changes to this bug.