360821 - Event creation fails if calendar view was not shown before

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Event creation fails if calendar view was not shown before

Steps to Reproduce:
1. Start Thunderbird. Do _not_ switch to calendar view!
2. Select File->New->Event or press the toolbar button

Actual Results:
Nothing happens. Console shows the following error:
  Error: this.mStartDate has no properties
  Source: chrome://calendar/content/calendar-multiday-view.xml line: 2151

Expected Results:
New event dialog is shown.

Regression date:
 Works in Lightning/0.4a1 (2006110607)
 Fails in Lightning/0.4a1 (2006110708)

Additional Information:
If one of the calendar views is displayed before the event creation works. But in difference to the previous build the event time is now always initialized with 00:00 instead of the current time as before.

Comment 1

[Stefan Sitter [:ssitter]]

Using Lightning/0.4a1 (2006111506) the error location has changed:
  Error: this.mStartDate has no properties
  Source: chrome://calendar/content/calendar-multiday-view.xml Line: 2175

Comment 2

[Stefan Sitter [:ssitter]]

Checkins to directory mozilla/calendar during regression range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fcalendar&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-06+07%3A00&maxdate=2006-11-07+09%3A00&cvsroot=%2Fcvsroot

The checkin for Bug 346934 looks like the culprit.

Comment 3

[Joey Minta]

Attachment: check calICalendarView::initialized

I still don't have a good environment for testing lightning, but this should solve the problem.  Would love if someone could confirm.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

I bet Clint can test/review this.

Comment 5

[cmtalbert]

Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

Looks good. Tested on WinXP 20061121 Thunderbird, with Lightning as of 20061201 (dev build).

Comment 6

[Matthew (lilmatt) Willis]

This bug is very ugly.  We have a patch in hand.  I think this has a shot at landing soon, so it can block 0.5 for now.

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 247618 [details] [diff] [review]
check calICalendarView::initialized

r=lilmatt

Comment 8

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 9

[Martin Schröder [:mschroeder]]

VERIFIED with Tb 2.0.0.4pre & Lightning 0.5pre (2007052205) on WindowsXP.