Expose pref for saving session state

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Stuart Morgan, Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1.2})

Trunk
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.2
Dependency tree / graph
Bug Flags:
camino1.1b1 +

Details

Attachments

(2 attachments)

4.01 KB, patch
Chris Lawson (gone)
: review+
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Stuart Morgan
: superreview+
Details | Diff | Splinter Review
9.46 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Details
(Reporter)

Description

12 years ago
Once we do something sane in the crash case (bug 358689), we need a GUI pref for automagic session save/restore (camino.remember_window_state).
(Reporter)

Updated

12 years ago
Target Milestone: --- → Camino1.1
(Assignee)

Updated

12 years ago
Whiteboard: [Good First Bug]
We'll need to do this before b1 if it's to make 1.1.
Flags: camino1.1b1?

Updated

12 years ago
Depends on: 363600

Comment 2

12 years ago
Per IRC, blocking b1.
Flags: camino1.1b1? → camino1.1b1+
Ian and I discussed some wording along the lines of

When Camino opens: [x] Restore the pages I was viewing when I quit

The wording's not great yet, but I think that's a viable ballpark.  The thing we have to be very careful about is length; we can't make the left side much longer than it already is in General, but we also need the right side to not be too long.
(Assignee)

Comment 4

12 years ago
Another thing we have to think about is making it clear that having this pref on stomps the "homepage in new window" pref when launching the app (unless we decide that that's a bug and change that).
(Reporter)

Comment 5

12 years ago
(In reply to comment #4)
> Another thing we have to think about is making it clear that having this pref
> on stomps the "homepage in new window" pref when launching the app

I don't follow; what pref is this, and how is it stomped?
(Assignee)

Comment 6

12 years ago
Created attachment 252946 [details] [diff] [review]
Patch
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #252946 - Flags: review?(bugzilla)
(Assignee)

Comment 7

12 years ago
Created attachment 252947 [details]
New Navigation.nib

This uses the string in comment 3 (and should therefore probably get textual polish).
Attachment #252947 - Flags: review?(alqahira)

Comment 8

12 years ago
Comment on attachment 252946 [details] [diff] [review]
Patch

r=me pending a successful test by Smokey of both code and nib changes.
Attachment #252946 - Flags: review?(bugzilla) → review+
Comment on attachment 252947 [details]
New Navigation.nib

r=ardissone, but please make the min height = current height on checkin

Anyone have any better ideas for the text?  It's OK, but it doesn't sound quite as polished as our usual efforts ;)
Attachment #252947 - Flags: review?(alqahira) → review+
cl suggested 

When Camino opens: [x] Load the pages I was viewing when I quit

which keeps the same verbs as the other prefs there, and sounds better (as well as removes ambiguity of "restore", since we don't actually restore page state, scroll position, DHTML, etc.).  

We'd both prefer something that removed the first person there, if possible.
When opening Camino: [x] Load the pages from the last time it was open

When Camino starts: [x] Load the pages that were open before quitting


Ian thinks the latter is the best suggestion so far.
(Reporter)

Comment 12

12 years ago
Comment on attachment 252946 [details] [diff] [review]
Patch

sr=smorgan with:
When Camino starts: [x] Load the pages that were open before quitting
Attachment #252946 - Flags: superreview?(stuart.morgan) → superreview+
Whiteboard: [Good First Bug] → [needs checkin with new text]
(Assignee)

Comment 13

12 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH with new text (comment 12) and min height fix (comment 9)
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
Whiteboard: [needs checkin with new text]
You need to log in before you can comment on or make changes to this bug.