Periodically auto-save window state for crash recovery

RESOLVED FIXED in Camino1.5

Status

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

({fixed1.8.1.1})

Dependency tree / graph

Details

Attachments

(1 attachment)

fix
7.05 KB, patch
bugzilla-graveyard
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Assignee

Description

13 years ago
I'm splitting this out from bug 358689, leaving that one for adding UI to let users avoid crash loops. This is the portion that actually does the periodic auto-saving, which we can go ahead with now since it's a hidden pref, so the people turning it on can know to go nuke the file if they get into a bad state.
Assignee

Comment 1

13 years ago
Posted patch fixSplinter Review
Saves periodically, coalescing events for 60 seconds before writing to disk.  Doing it this way should also reduce the chance of getting a bad state saved, since we won't usually be saving just as a page loads.

Also fixes a typo I noticed in a dictionary key. Once this lands anyone using the session-saving pref will, one time only, have their saved session open with all their bookmark bars hidden. It's still a hidden pref and that's a pretty minor issue, so I'd much rather do that than add migrating code that only a handful of early-adopters will need.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #248398 - Flags: review?

Updated

13 years ago
Assignee: stuart.morgan → nobody
Status: ASSIGNED → NEW
Sorry about that. Mouse slipped when CCing myself.
Assignee: nobody → stuart.morgan

Updated

13 years ago
Target Milestone: --- → Camino1.1
Comment on attachment 248398 [details] [diff] [review]
fix

>+// Notifies the SessionManager that the windows state has changed. This

s/windows/window

r=me with that change, code-wise. I didn't test, though.
Attachment #248398 - Flags: review? → review+
Assignee

Comment 4

13 years ago
Comment on attachment 248398 [details] [diff] [review]
fix

I'll fix the typo on checkin.
Attachment #248398 - Flags: superreview?(mikepinkerton)

Updated

13 years ago
Blocks: 360839
Oh, I meant to ask this earlier...does this patch address the problem raised by bug 361092?

cl
Assignee

Comment 6

13 years ago
Nope.
Comment on attachment 248398 [details] [diff] [review]
fix

sr=pink
Attachment #248398 - Flags: superreview?(mikepinkerton) → superreview+
Assignee

Comment 8

13 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.