360870 - [FIX]Consider eliminating the arithmetic in GetStyleData

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I tried replacing some of the GetStyleData callsites with GetStyle**** functions I added using our macro stuff.  This allows getting a style struct without having to do a bunch of pointer arithmetic, at the expense of multiple functions around...

This patch seems to give maybe a 1% speedup on large table pages (which is where I was seeing a lot of GetStyleData going on).  I think it's worth at least trying on trunk.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 245734 [details] [diff] [review]
Like so

How hard would it be to eliminate the GetStyleData(nsStyleStructID) APIs?  What still uses them?  I'm not crazy about the idea of keeping both APIs around.

r+sr=dbaron

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That said, I'd like to make nsRuleNode more table driven to implement some advanced css3-values features (see bug 332335 and dependencies), so I may want to revert part of the nsRuleNode changes here at some point.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The main consumers of GetStyleData left after this change are computed style (which would need some thought to fix) and nsRuleNode itself -- WalkRuleTree calls it on the parent style context.  That one is the really tough one.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Merged to tip

Comment 6

[Boris Zbarsky [:bzbarsky]]

Filed bug 363605 on computed style, and checked in.