360872 - DOM event handlers can fire while a modal dialog is open

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 52209 comment 16.

Comment 1

[Mike Schroepfer]

Bz  - do you think we want to tackle this for 1.9 or differ it?  

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't really know, to be honest.  We should really just fix the GTK bug I mention in that comment, but I doubt we have anyone working on that sort of stuff.  Really, we should fix our modality bugs in general, at which point this _might_ become a non-issue.

And somehow delaying event handler execution would be a lot of work.  :(

Maybe we can just disable script on a page while it has a modal dialog up?

Comment 3

[Johnny Stenback (:jst)]

On second thought, we're not going to block on this.

Not sure how much of this is worth looking into for now, but Karl, see bug 52209 comment 16, anything we can do about GTK event handlers here?

Comment 4

[Karl Tomlinson (:karlt)]

Is this fixed by Matthew's patch (which has landed) in bug 290862 comment 13?

Comment 5

[Matthew Gregan [:kinetik]]

The patch fixes the key event dispatch that Boris mentions: "At least on GTK key events get dispatched to the main window while a modal dialog is up.  :(", but not the other issues mentioned.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmm.  Do we still dispatch mousemove events?  Or no?

If we no longer dispatch user events, that would only leave things like onload and whatnot, right?

Comment 7

[Karl Tomlinson (:karlt)]

(In reply to comment #6)
> Hmm.  Do we still dispatch mousemove events?  Or no?

Not on Linux, but Bug 324149 is about that on Windows.

Comment 8

[Boris Zbarsky [:bzbarsky]]

What about focus/blur?  Or just when the alert comes up and down?

Comment 9

[Karl Tomlinson (:karlt)]

Well, not focus/blur.

But some mouse motion events are still happening on Linux as demonstrated by attachment 287639 [details].