361191 - In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get out of it.

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Mark Banner (:standard8)]

On suiterunner builds go into preferences and Select Mail & Newsgroups, followed by Tags. Then try to select another pane - it doesn't change, the console comes up with:

JavaScript error: chrome://messenger/content/pref-labels.js, line 90: aPageData has no properties

Comment 1

[Mark Banner (:standard8)]

This seems to be due to http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/pref-labels.js#296

I think:

var pageData    = parent.hPrefWindow.wsm.dataManager.pageData[TAGPANEL_URI];

should be:

var pageData    = parent.hPrefWindow.wsm.dataManager.getPageData(TAGPANEL_URI);

based on https://bugzilla.mozilla.org/attachment.cgi?id=227764

but I won't have a build available to me until later to try this on.

Comment 2

[Mark Banner (:standard8)]

I have a patch that should fix this.

Comment 3

[Mark Banner (:standard8)]

Attachment: Possible fix

This fixes the problem. Just need to check for regressions on xpfe.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 246053 [details] [diff] [review]
Possible fix

This seems to work ok in both xpfe & toolkit suiterunner, requesting reviews.

Comment 5

[Ian Neal]

Comment on attachment 246053 [details] [diff] [review]
Possible fix

I would expect there to be the same problem with pref-cache.xul and possibly pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields in http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168 too

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> (From update of attachment 246053 [details] [diff] [review] [edit])
> I would expect there to be the same problem with pref-cache.xul and possibly
> pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields
> in
> http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168
> too

There is a problem with pref-cache.xul, I tried a similar fix but for some reason couldn't get it to work. pref-fonts.js I hadn't picked up on a problem, but I may have missed that.

I'll have to have another look.

Comment 7

[Mark Banner (:standard8)]

The SeaMonkey patch on bug 374404 that I've just committed has fixed this as we now use xpfe's wsm for suiterunner rather than toolkit's.