In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get out of it.

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

13 years ago
On suiterunner builds go into preferences and Select Mail & Newsgroups, followed by Tags. Then try to select another pane - it doesn't change, the console comes up with:

JavaScript error: chrome://messenger/content/pref-labels.js, line 90: aPageData has no properties
Assignee

Updated

13 years ago
Summary: In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get off it. → In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get of it.
Summary: In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get of it. → In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get out of it.
Assignee

Comment 1

13 years ago
This seems to be due to http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/pref-labels.js#296

I think:

var pageData    = parent.hPrefWindow.wsm.dataManager.pageData[TAGPANEL_URI];

should be:

var pageData    = parent.hPrefWindow.wsm.dataManager.getPageData(TAGPANEL_URI);

based on https://bugzilla.mozilla.org/attachment.cgi?id=227764

but I won't have a build available to me until later to try this on.
Assignee

Comment 2

13 years ago
I have a patch that should fix this.
Assignee: prefs → bugzilla
Assignee

Comment 3

13 years ago
Posted patch Possible fixSplinter Review
This fixes the problem. Just need to check for regressions on xpfe.
Assignee

Comment 4

13 years ago
Comment on attachment 246053 [details] [diff] [review]
Possible fix

This seems to work ok in both xpfe & toolkit suiterunner, requesting reviews.
Attachment #246053 - Flags: review?(iann_bugzilla)

Comment 5

13 years ago
Comment on attachment 246053 [details] [diff] [review]
Possible fix

I would expect there to be the same problem with pref-cache.xul and possibly pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields in http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168 too
Attachment #246053 - Flags: review?(iann_bugzilla) → review-
Assignee

Comment 6

13 years ago
(In reply to comment #5)
> (From update of attachment 246053 [details] [diff] [review] [edit])
> I would expect there to be the same problem with pref-cache.xul and possibly
> pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields
> in
> http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168
> too

There is a problem with pref-cache.xul, I tried a similar fix but for some reason couldn't get it to work. pref-fonts.js I hadn't picked up on a problem, but I may have missed that.

I'll have to have another look.
Assignee

Updated

12 years ago
Depends on: 374404
Assignee

Comment 7

12 years ago
The SeaMonkey patch on bug 374404 that I've just committed has fixed this as we now use xpfe's wsm for suiterunner rather than toolkit's.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.